Skip to content

Add more metrics to be collected by ethtool in network check#23884

Open
steveny91 wants to merge 4 commits into
masterfrom
sy/mlx5-roce-ethtool
Open

Add more metrics to be collected by ethtool in network check#23884
steveny91 wants to merge 4 commits into
masterfrom
sy/mlx5-roce-ethtool

Conversation

@steveny91
Copy link
Copy Markdown
Contributor

@steveny91 steveny91 commented May 29, 2026

What does this PR do?

Adds new metrics to be collected by the network checks. The metrics are mostly for Mellanox driver that are emitted from ethtool.

https://docs.kernel.org/networking/device_drivers/ethernet/mellanox/mlx5/counters.html

This check got migrated to Go, so this change is mainly for keeping parity and also include the metadata.csv entries.

@datadog-prod-us1-6
Copy link
Copy Markdown

datadog-prod-us1-6 Bot commented May 29, 2026

Tests  Code Coverage

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 77.52%

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 611828b | Docs | Datadog PR Page | Give us feedback!

@steveny91 steveny91 added the qa/skip-qa Automatically skip this PR for the next QA label May 29, 2026
@steveny91 steveny91 changed the title add more metrics to be collected by ethtool in network check Add more metrics to be collected by ethtool in network check May 29, 2026
@steveny91 steveny91 marked this pull request as ready for review May 29, 2026 20:05
@steveny91 steveny91 requested review from a team as code owners May 29, 2026 20:05
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 29, 2026

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant