test(tck): un-skip null/boolean scalar scenarios — passing 9 → 18 (#598)#900
Merged
Conversation
Per-scenario un-skip of the verified-passing scenarios in three expression features, using the #889-slice-2 machine: - Null3 [1][2][3] (null inverse / null = null / null <> null); - Boolean1 [1][2][3] (conjunction of N truth values); - Boolean2 [1][2][3] (disjunction of N truth values). Each confirmed green by running the BDD suite (not the static classifier, which over-predicted). The remaining scenarios — null truth-table commutativity/associativity, `IN` with null, IS NULL on properties/maps, and the type-error "Fail on …" outlines — stay tagged `@skip-rust` pending the features they need. coverage_matrix.json regenerated: corpus scenarios_passing 9 → 18; these three features now `partial`. BDD 18/18, tck_coverage green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
WalkthroughThree TCK feature files ( ChangesTCK Rust skip granularity and coverage matrix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advances #598. First batch using the per-scenario un-skip machine from #889 slice 2.
What
Un-skips the verified-passing scenarios of three expression features (per-scenario — remove the feature-level
@skip-rust, tag only the still-unsupported scenarios):Null3 [1][2][3]— null inverse,null = null,null <> null;Boolean1 [1][2][3]— conjunction of N truth values;Boolean2 [1][2][3]— disjunction of N truth values.Each was confirmed green by running the BDD suite (not the static classifier, which over-predicted ~7×). The rest stay
@skip-rust: null truth-table commutativity/associativity,IN-with-null,IS NULLon properties/maps, and the type-error "Fail on …" outlines.Corpus scenarios_passing: 9 → 18. These three features are now
partial.Validation
tck_coveragegreen (4partialfeatures now;_meta.scenarios_passing= 18); fmt clean (corpus + matrix only, no code).🤖 Generated with Claude Code
Note
Un-skip passing null/boolean TCK scenarios, increasing corpus from 9 to 18
Removes file-level
@skip-rusttags from Boolean1.feature, Boolean2.feature, and Null3.feature, replacing them with per-scenario@skip-rusttags only on scenarios that still fail. Updates coverage_matrix.json to reflect 18 total passing scenarios and marks those three features aspartialwith 3 passing scenarios each.Macroscope summarized afd2745.
Summary by CodeRabbit