Skip to content

test(tck): un-skip null/boolean scalar scenarios — passing 9 → 18 (#598)#900

Merged
DecisionNerd merged 1 commit into
mainfrom
feature/598-unskip-batch-1
Jun 23, 2026
Merged

test(tck): un-skip null/boolean scalar scenarios — passing 9 → 18 (#598)#900
DecisionNerd merged 1 commit into
mainfrom
feature/598-unskip-batch-1

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Jun 23, 2026

Copy link
Copy Markdown
Owner

Advances #598. First batch using the per-scenario un-skip machine from #889 slice 2.

What

Un-skips the verified-passing scenarios of three expression features (per-scenario — remove the feature-level @skip-rust, tag only the still-unsupported scenarios):

  • Null3 [1][2][3] — null inverse, null = null, null <> null;
  • Boolean1 [1][2][3] — conjunction of N truth values;
  • Boolean2 [1][2][3] — disjunction of N truth values.

Each was confirmed green by running the BDD suite (not the static classifier, which over-predicted ~7×). The rest stay @skip-rust: null truth-table commutativity/associativity, IN-with-null, IS NULL on properties/maps, and the type-error "Fail on …" outlines.

Corpus scenarios_passing: 9 → 18. These three features are now partial.

Validation

  • BDD corpus 18/18; tck_coverage green (4 partial features now; _meta.scenarios_passing = 18); fmt clean (corpus + matrix only, no code).

🤖 Generated with Claude Code

Note

Un-skip passing null/boolean TCK scenarios, increasing corpus from 9 to 18

Removes file-level @skip-rust tags from Boolean1.feature, Boolean2.feature, and Null3.feature, replacing them with per-scenario @skip-rust tags only on scenarios that still fail. Updates coverage_matrix.json to reflect 18 total passing scenarios and marks those three features as partial with 3 passing scenarios each.

Macroscope summarized afd2745.

Summary by CodeRabbit

  • Tests
    • Expanded Rust runtime test coverage for boolean and null expression scenarios, transitioning from fully skipped to partial execution.
    • Updated test compatibility matrix to reflect improved passing scenario counts.

Per-scenario un-skip of the verified-passing scenarios in three
expression features, using the #889-slice-2 machine:

- Null3 [1][2][3] (null inverse / null = null / null <> null);
- Boolean1 [1][2][3] (conjunction of N truth values);
- Boolean2 [1][2][3] (disjunction of N truth values).

Each confirmed green by running the BDD suite (not the static
classifier, which over-predicted). The remaining scenarios — null
truth-table commutativity/associativity, `IN` with null, IS NULL on
properties/maps, and the type-error "Fail on …" outlines — stay tagged
`@skip-rust` pending the features they need.

coverage_matrix.json regenerated: corpus scenarios_passing 9 → 18; these
three features now `partial`. BDD 18/18, tck_coverage green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Three TCK feature files (Boolean1.feature, Boolean2.feature, Null3.feature) have their @skip-rust annotation moved from the feature level to individual later scenarios (commutativity, associativity, and type-error cases). Early scenarios in each file now run under Rust. The coverage_matrix.json is updated to reflect rust_status: "partial" and increased scenarios_passing counts.

Changes

TCK Rust skip granularity and coverage matrix

Layer / File(s) Summary
Feature-level and per-scenario @skip-rust tag changes
tests/tck/features/expressions/boolean/Boolean1.feature, tests/tck/features/expressions/boolean/Boolean2.feature, tests/tck/features/expressions/null/Null3.feature
Feature-level @skip-rust @skip-node`` is replaced with @skip-node only in all three files. Explicit `@skip-rust` tags are added before scenarios [4]–[8] in both boolean files (commutativity, associativity, and compile-time type error outlines) and before a later null-evaluation scenario in `Null3.feature`, preserving Rust skipping only for those specific cases.
Coverage matrix counts updated
tests/tck/coverage_matrix.json
rust_status changes from "skip" to "partial" for Boolean1.feature, Boolean2.feature, and Null3.feature; scenarios_passing increases from 0 to 3 for each; _meta total scenarios_passing increases from 9 to 18.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • DecisionNerd/graphforge#887: Adjusts @skip-rust usage in expressions/literals/Literals1.feature using the same tag-restructuring pattern applied here to boolean and null features.
  • DecisionNerd/graphforge#891: Adds tck_coverage.rs validation that enforces the rust_status/scenarios_passing counts in coverage_matrix.json that this PR updates.
  • DecisionNerd/graphforge#899: Introduces the per-scenario accounting logic in coverage_matrix.json (matrix v2) that this PR's updated counts depend on.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: un-skipping null/boolean test scenarios and the resulting increase in passing scenarios from 9 to 18.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description is comprehensive, well-structured, and includes clear explanations of changes, validation results, and references to related issues.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/598-unskip-batch-1

Comment @coderabbitai help to get the list of available commands.

@DecisionNerd DecisionNerd merged commit b039783 into main Jun 23, 2026
41 checks passed
@DecisionNerd DecisionNerd deleted the feature/598-unskip-batch-1 branch June 23, 2026 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant