Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]

### In Development — v0.5.0 (Rust Core, `rust-core` branch)
- TCK un-skip batch — null/boolean scalar scenarios (#598) — un-skipped the
verified-passing scenarios of `Null3`, `Boolean1`, `Boolean2` (per-scenario;
the null-truth-table, `IN`, and type-error scenarios stay `@skip-rust`).
Corpus passing 9 → 18. Each was confirmed green by running, not predicted.
- `CREATE` of an anonymous path binds its edge endpoints (#598/#601) —
`CREATE (:A)-[:REL]->(:B)` no longer errors `CREATE edge references unbound
dst var`. `lower_create` carried the same anonymous-destination bug fixed for
Expand Down
14 changes: 7 additions & 7 deletions tests/tck/coverage_matrix.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"corpus": "openCypher TCK tag 2024.3 (vendored, #874)",
"feature_files": 220,
"scenarios_total": 3880,
"scenarios_passing": 9,
"scenarios_passing": 18,
"scenarios_written": 1615,
"note": "Per-scenario aware (#889). 'scenarios' is the EXPANDED runnable count cucumber runs (Scenario=1; Scenario Outline=one per Examples data row). 'scenarios_passing' is the subset that RUNS: a scenario runs unless the feature OR the scenario carries @skip-rust (the BDD runner uses fail_on_skipped, so a runnable scenario that failed would fail CI). rust_status: 'passing'=all run, 'partial'=some run (per-scenario @skip-rust on the rest), 'skip'=none. scenarios_total (3880) is the 100%-gate denominator (#609/#742). Regression floor: do not lower a feature's scenarios_passing. crates/gf-api/tests/tck_coverage.rs recomputes all of this from the feature files and fails CI on drift."
},
Expand Down Expand Up @@ -514,14 +514,14 @@
"scenarios_passing": 0
},
"expressions/boolean/Boolean1.feature": {
"rust_status": "skip",
"rust_status": "partial",
"scenarios": 30,
"scenarios_passing": 0
"scenarios_passing": 3
},
"expressions/boolean/Boolean2.feature": {
"rust_status": "skip",
"rust_status": "partial",
"scenarios": 30,
"scenarios_passing": 0
"scenarios_passing": 3
},
"expressions/boolean/Boolean3.feature": {
"rust_status": "skip",
Expand Down Expand Up @@ -839,9 +839,9 @@
"scenarios_passing": 0
},
"expressions/null/Null3.feature": {
"rust_status": "skip",
"rust_status": "partial",
"scenarios": 10,
"scenarios_passing": 0
"scenarios_passing": 3
},
"expressions/path/Path1.feature": {
"rust_status": "skip",
Expand Down
7 changes: 6 additions & 1 deletion tests/tck/features/expressions/boolean/Boolean1.feature
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

#encoding: utf-8

@skip-rust @skip-node
@skip-node
Feature: Boolean1 - And logical operations

Scenario: [1] Conjunction of two truth values
Expand Down Expand Up @@ -109,6 +109,7 @@ Feature: Boolean1 - And logical operations
| true | false | null | false | false | false | null | null | false | false | false | false |
And no side effects

@skip-rust
Scenario: [4] Conjunction is commutative on non-null
Given any graph
When executing query:
Expand All @@ -125,6 +126,7 @@ Feature: Boolean1 - And logical operations
| false | false | true |
And no side effects

@skip-rust
Scenario: [5] Conjunction is commutative on null
Given any graph
When executing query:
Expand All @@ -143,6 +145,7 @@ Feature: Boolean1 - And logical operations
| null | null | true |
And no side effects

@skip-rust
Scenario: [6] Conjunction is associative on non-null
Given any graph
When executing query:
Expand All @@ -164,6 +167,7 @@ Feature: Boolean1 - And logical operations
| false | false | false | true |
And no side effects

@skip-rust
Scenario: [7] Conjunction is associative on null
Given any graph
When executing query:
Expand Down Expand Up @@ -197,6 +201,7 @@ Feature: Boolean1 - And logical operations
| null | null | null | true |
And no side effects

@skip-rust
Scenario Outline: [8] Fail on conjunction of at least one non-booleans
Given any graph
When executing query:
Expand Down
7 changes: 6 additions & 1 deletion tests/tck/features/expressions/boolean/Boolean2.feature
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

#encoding: utf-8

@skip-rust @skip-node
@skip-node
Feature: Boolean2 - OR logical operations

Scenario: [1] Disjunction of two truth values
Expand Down Expand Up @@ -109,6 +109,7 @@ Feature: Boolean2 - OR logical operations
| true | true | true | false | true | null | null | true | null | true | true | true |
And no side effects

@skip-rust
Scenario: [4] Disjunction is commutative on non-null
Given any graph
When executing query:
Expand All @@ -125,6 +126,7 @@ Feature: Boolean2 - OR logical operations
| false | false | true |
And no side effects

@skip-rust
Scenario: [5] Disjunction is commutative on null
Given any graph
When executing query:
Expand All @@ -143,6 +145,7 @@ Feature: Boolean2 - OR logical operations
| null | null | true |
And no side effects

@skip-rust
Scenario: [6] Disjunction is associative on non-null
Given any graph
When executing query:
Expand All @@ -164,6 +167,7 @@ Feature: Boolean2 - OR logical operations
| false | false | false | true |
And no side effects

@skip-rust
Scenario: [7] Disjunction is associative on null
Given any graph
When executing query:
Expand Down Expand Up @@ -197,6 +201,7 @@ Feature: Boolean2 - OR logical operations
| null | null | null | true |
And no side effects

@skip-rust
Scenario Outline: [8] Fail on disjunction of at least one non-booleans
Given any graph
When executing query:
Expand Down
3 changes: 2 additions & 1 deletion tests/tck/features/expressions/null/Null3.feature
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

#encoding: utf-8

@skip-rust @skip-node
@skip-node
Feature: Null3 - Null evaluation
# the scenarios of this feature should be redistributed to the features of respective operations

Expand Down Expand Up @@ -65,6 +65,7 @@ Feature: Null3 - Null evaluation
| null |
And no side effects

@skip-rust
Scenario Outline: [4] Using null in IN
Given any graph
And parameters are:
Expand Down
Loading