Skip to content

Enable Factory Droid automated code review#1601

Open
EffortlessSteven wants to merge 2 commits into
mainfrom
add-factory-workflows-20260504024339
Open

Enable Factory Droid automated code review#1601
EffortlessSteven wants to merge 2 commits into
mainfrom
add-factory-workflows-20260504024339

Conversation

@EffortlessSteven
Copy link
Copy Markdown
Member

This PR adds Factory Droid automated code review workflows.

  • droid.yml: Responds to @droid mentions
  • droid-review.yml: Automatic code review on new PRs

Generate a key at https://app.factory.ai/settings/api-keys
Docs: https://docs.factory.ai

@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@factory-droid
Copy link
Copy Markdown

factory-droid Bot commented May 4, 2026

Droid encountered an error —— View job


Droid is reviewing code and running a security check…

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 36 minutes and 49 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: af937198-df18-4dc8-ad16-b927cfbaefa3

📥 Commits

Reviewing files that changed from the base of the PR and between 3e1d9e1 and 7bac5a0.

📒 Files selected for processing (2)
  • .github/workflows/droid-review.yml
  • .github/workflows/droid.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-factory-workflows-20260504024339

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 36 minutes and 49 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@factory-droid
Copy link
Copy Markdown

factory-droid Bot commented May 4, 2026

Droid encountered an error —— View job


Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7bac5a0d8d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


on:
pull_request:
types: [opened, ready_for_review, reopened]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add synchronize to auto-review PR triggers

The auto-review workflow only runs on opened, ready_for_review, and reopened, so it does not execute when new commits are pushed to an existing PR (pull_request synchronize events). This leaves later changes unreviewed by Droid unless someone manually retriggers it, which defeats continuous PR coverage and can miss regressions introduced after the initial review.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Member Author

Triaged during a batch PR review. Not merging — two concerns to resolve first:

  1. Branch is behind main. Both workflows have checkout@v5, which is fine, but the PR was opened May 4 and main has moved substantially since. Click "Update branch" or rebase, then let CI re-run.
  2. Action pinning. Both workflows use Factory-AI/droid-action@main, an unpinned mutable ref. This is exactly the supply-chain hardening pattern PR Pin GitHub Actions to SHA commits for security hardening #1552 set out to remove from the rest of the workflows. Pin to a commit SHA (e.g. Factory-AI/droid-action@<sha> # v1.x) before merging.

Also worth checking that FACTORY_API_KEY is configured in the repo's Actions secrets, otherwise both jobs will silently fail at the Run Droid* step the first time they execute. The Gate: Issue linked failure on the current run will also need a linked issue or an exemption.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant