NUClearNet 2 (protocol 0x03)#29
Open
TrentHouliston wants to merge 10 commits into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
git-subtree-dir: src/nuclear git-subtree-split: ce389fbfea56ce97527474865dc343e0c087bd70
Migrate the addon to NUClear::network::NUClearNet (protocol 0x03), wire typed event listeners through add/setSubscriptions, and release as 2.0.0. Co-authored-by: Cursor <cursoragent@cursor.com>
Patch NUClearNet send_buf for MSVC WSABUF fields, link ws2_32 on Windows, skip multicast-dependent tests on GitHub macOS runners, and add a Docker Linux test path plus workflow job. Co-authored-by: Cursor <cursoragent@cursor.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| uint32_t port = arg_port.IsNumber() ? arg_port.As<Napi::Number>().Uint32Value() : 7447; | ||
| uint32_t network_mtu = arg_mtu.IsNumber() ? arg_mtu.As<Napi::Number>().Uint32Value() : 1500; | ||
| network::NetworkConfig config; | ||
| config.announce_address = "239.226.152.162"; |
| } | ||
|
|
||
| // Then verify multicast actually works with a real round-trip | ||
| return test_multicast_roundtrip(AF_INET, "239.255.255.250"); |
| } | ||
|
|
||
| // Then verify multicast actually works with a real round-trip | ||
| return test_multicast_roundtrip(AF_INET6, "ff02::1"); |
| NetworkConfig make_config(const std::string& name) { | ||
| NetworkConfig config; | ||
| config.name = name; | ||
| config.announce_address = "239.226.152.162"; |
Use a make_iovec helper for WSABUF initialization, call NUClear::sendmsg on Windows, and omit msg_flags where WSAMSG has no flags member. Co-authored-by: Cursor <cursoragent@cursor.com>
Introduce Log.hpp/Log.cpp with off-through-trace levels, instrument Discovery and NUClearNet for handshake and wire events, and expose setLogLevel through the Node binding plus JS connect/debug options. Co-authored-by: Cursor <cursoragent@cursor.com>
Pull in NUClear@c1bf7d4 (debug logging on current houliston/nuclearnet-v2) including socket rebind and existing WSABUF/sendmsg Windows build support. Co-authored-by: Cursor <cursoragent@cursor.com>
Pull PR #190 review fixes: fragment validation, Discovery/Reliability hardening, LogLevel/MSVC CI fixes, and related nuclearnet updates. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
houliston/nuclearnet-v2(NUClear PR #190, commitce389fbf)NUClearNetworkaddon build with the standalonesrc/nuclearnetlibraryNetworkBindingfor the newNUClear::network::NUClearNetAPI (handshake, protocol 0x03)on('message.type')listeners withaddSubscription/setSubscriptions(same pattern as NUClearNetworkController)Test plan
npm run build(macOS)npm test— 10/10 passing locallyMade with Cursor