Skip to content

NUClearNet 2 (protocol 0x03) #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TrentHouliston wants to merge 10 commits into
base: main
Choose a base branch
from
+21,006 −8,048

Update README NUClear subtree pin to 2441bdf

dca27a2
Select commit
Loading
Failed to load commit list.
Open

NUClearNet 2 (protocol 0x03) #29

Update README NUClear subtree pin to 2441bdf
dca27a2
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jun 4, 2026 in 2m 49s

Quality Gate failed

Failed conditions
10 Security Hotspots
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 674 in src/nuclear/src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "reinterpret_cast" with a safer operation. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOurS3uyRsdjYRkI&open=AZ6MEOurS3uyRsdjYRkI&pullRequest=29

Check warning on line 122 in src/nuclear/src/nuclearnet/Discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the commented out code. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOtGS3uyRsdjYRjR&open=AZ6MEOtGS3uyRsdjYRjR&pullRequest=29

Check warning on line 115 in src/nuclear/src/nuclearnet/Reliability.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this specialization with "bool" of "std::vector". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOtwS3uyRsdjYRjY&open=AZ6MEOtwS3uyRsdjYRjY&pullRequest=29

Check warning on line 65 in src/nuclear/src/nuclearnet/Routing.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid explicitly specifying the template arguments by relying on the class template argument deduction. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOu8S3uyRsdjYRki&open=AZ6MEOu8S3uyRsdjYRki&pullRequest=29

Check failure on line 28 in src/nuclear/src/util/precise_sleep.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this include of "ctime". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOxkS3uyRsdjYRlj&open=AZ6MEOxkS3uyRsdjYRlj&pullRequest=29

Check warning on line 369 in src/nuclear/src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "reinterpret_cast" with a "static_cast". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MGCbnaGUIhYcus1Nt&open=AZ6MGCbnaGUIhYcus1Nt&pullRequest=29

Check warning on line 80 in src/nuclear/tests/tests/nuclearnet/ProcessPacket.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this specialization with "bool" of "std::vector". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEO6WS3uyRsdjYRmu&open=AZ6MEO6WS3uyRsdjYRmu&pullRequest=29

Check warning on line 153 in src/nuclear/tests/test_util/has_multicast.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "reinterpret_cast" with a safer operation. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEO9AS3uyRsdjYRox&open=AZ6MEO9AS3uyRsdjYRox&pullRequest=29

Check warning on line 198 in src/nuclear/src/nuclearnet/Reliability.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "std::lock_guard" with "std::scoped_lock" 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOvFS3uyRsdjYRlD&open=AZ6MEOvFS3uyRsdjYRlD&pullRequest=29

Check warning on line 426 in src/nuclear/src/nuclearnet/Discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid explicitly specifying the template arguments by relying on the class template argument deduction. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOtGS3uyRsdjYRjD&open=AZ6MEOtGS3uyRsdjYRjD&pullRequest=29

Check warning on line 204 in src/nuclear/src/nuclearnet/Reliability.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "std::lock_guard" with "std::scoped_lock" 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOvFS3uyRsdjYRlF&open=AZ6MEOvFS3uyRsdjYRlF&pullRequest=29

Check warning on line 756 in src/nuclear/src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this specialization with "bool" of "std::vector". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOurS3uyRsdjYRkP&open=AZ6MEOurS3uyRsdjYRkP&pullRequest=29

Check warning on line 420 in src/nuclear/src/nuclearnet/Discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid explicitly specifying the template arguments by relying on the class template argument deduction. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOtGS3uyRsdjYRjB&open=AZ6MEOtGS3uyRsdjYRjB&pullRequest=29

Check warning on line 722 in src/nuclear/src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::byte" for byte-oriented data manipulation. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOurS3uyRsdjYRkL&open=AZ6MEOurS3uyRsdjYRkL&pullRequest=29

Check warning on line 471 in src/nuclear/src/nuclearnet/Discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid explicitly specifying the template arguments by relying on the class template argument deduction. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOtGS3uyRsdjYRjK&open=AZ6MEOtGS3uyRsdjYRjK&pullRequest=29

Check warning on line 488 in src/nuclear/src/nuclearnet/Discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid explicitly specifying the template arguments by relying on the class template argument deduction. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6ManXxQFLKRviDQOlz&open=AZ6ManXxQFLKRviDQOlz&pullRequest=29

Check warning on line 56 in src/nuclear/src/nuclearnet/Reliability.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "std::lock_guard" with "std::scoped_lock" 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOvFS3uyRsdjYRkw&open=AZ6MEOvFS3uyRsdjYRkw&pullRequest=29

Check warning on line 314 in src/nuclear/src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"catch" a specific exception type. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6ManWwQFLKRviDQOlZ&open=AZ6ManWwQFLKRviDQOlZ&pullRequest=29

Check warning on line 42 in src/nuclear/src/extension/trace/protobuf.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "enable_if" with a language construct (i.e. use an abbreviate function template, a "requires" clause, or an "if constexpr"). 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOzAS3uyRsdjYRlu&open=AZ6MEOzAS3uyRsdjYRlu&pullRequest=29

Check failure on line 437 in src/NetworkBinding.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEO_eS3uyRsdjYRpM&open=AZ6MEO_eS3uyRsdjYRpM&pullRequest=29

Check failure on line 821 in src/nuclear/src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

const_cast removing const qualification from the type of a pointer may lead to an undefined behaviour. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOurS3uyRsdjYRkX&open=AZ6MEOurS3uyRsdjYRkX&pullRequest=29

Check warning on line 170 in src/nuclear/tests/test_util/has_multicast.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::string" instead of a C-style char array. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEO9AS3uyRsdjYRoy&open=AZ6MEO9AS3uyRsdjYRoy&pullRequest=29

Check failure on line 25 in src/nuclear/src/nuclearnet/Log.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this include of "cstdio". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6ManXUQFLKRviDQOlh&open=AZ6ManXUQFLKRviDQOlh&pullRequest=29

Check warning on line 89 in src/nuclear/tests/test_util/has_multicast.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "reinterpret_cast" with a safer operation. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEO9AS3uyRsdjYRop&open=AZ6MEO9AS3uyRsdjYRop&pullRequest=29

Check failure on line 123 in src/nuclear/tests/tests/nuclearnet/Integration.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEO7KS3uyRsdjYRn3&open=AZ6MEO7KS3uyRsdjYRn3&pullRequest=29
View more details on SonarQubeCloud