Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThis PR bumps the add-on version to 2.5.0-SNAPSHOT, adds a new Maven profile ChangesBuild and event extraction changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoly.java (1)
173-177: ⚡ Quick winAdd a Javadoc
@deprecatednote for the deprecated constructor.Line 173 is annotated
@Deprecated, but a matching Javadoc@deprecatedentry is missing. Add it with the replacement constructor for clearer API guidance and to satisfy the reported static-analysis warning.♻️ Proposed update
+ /** + * `@deprecated` Since 2.5.0, use + * {`@link` `#GoogleMapPolyClickEvent`(GoogleMapPoly, boolean, double, double)}. + */ `@Deprecated`(since = "2.5.0", forRemoval = true) public GoogleMapPolyClickEvent( GoogleMapPoly source, boolean fromClient, JsonValue latLng) {🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoly.java` around lines 173 - 177, Add a Javadoc "`@deprecated`" tag to the deprecated constructor GoogleMapPolyClickEvent(GoogleMapPoly source, boolean fromClient, JsonValue latLng) explaining it is deprecated since 2.5.0 and pointing callers to use the replacement constructor GoogleMapPolyClickEvent(GoogleMapPoly source, boolean fromClient, double lat, double lng) (or whatever the new signature is) — update the constructor's Javadoc block to include the `@deprecated` line with the version and the suggested replacement constructor name.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoly.java`:
- Around line 173-177: Add a Javadoc "`@deprecated`" tag to the deprecated
constructor GoogleMapPolyClickEvent(GoogleMapPoly source, boolean fromClient,
JsonValue latLng) explaining it is deprecated since 2.5.0 and pointing callers
to use the replacement constructor GoogleMapPolyClickEvent(GoogleMapPoly source,
boolean fromClient, double lat, double lng) (or whatever the new signature is) —
update the constructor's Javadoc block to include the `@deprecated` line with the
version and the suggested replacement constructor name.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: bb52c67c-1d0f-44d4-bb68-76671dd90da1
📒 Files selected for processing (2)
pom.xmlsrc/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoly.java
javier-godoy
force-pushed
the
fix-180
branch
2 times, most recently
from
2401322 to
f791878
Compare
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoly.java (1)
167-167: 💤 Low valueJavaDoc says "polygon" but the parameter accepts any GoogleMapPoly.
The JavaDoc states "the polygon that was clicked" but the parameter type is
GoogleMapPoly, which is abstract and likely supports both polygons and polylines. Consider updating the documentation to be more accurate.📝 Suggested documentation improvement
- * `@param` source the polygon that was clicked + * `@param` source the poly (polygon or polyline) that was clicked🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoly.java` at line 167, Update the JavaDoc to accurately describe the parameter type: replace references to "the polygon that was clicked" with wording that reflects the GoogleMapPoly abstraction (e.g., "the GoogleMapPoly (polygon or polyline) that was clicked") so the documentation matches the parameter type GoogleMapPoly; ensure any nearby doc tags (including the fromClient description) remain accurate and consistent with the method signature.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoly.java`:
- Line 190: Remove the Java-9-specific attributes from the Deprecated annotation
on GoogleMapPoly (replace `@Deprecated`(since = "2.5.0", forRemoval = true) with
plain `@Deprecated`) and add a Javadoc `@deprecated` tag above the class/method that
records the "since 2.5.0" and "for removal" information (e.g., in the JavaDoc
for GoogleMapPoly) so the compatibility with Java 8 is preserved while retaining
the version/removal notes.
---
Nitpick comments:
In `@src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoly.java`:
- Line 167: Update the JavaDoc to accurately describe the parameter type:
replace references to "the polygon that was clicked" with wording that reflects
the GoogleMapPoly abstraction (e.g., "the GoogleMapPoly (polygon or polyline)
that was clicked") so the documentation matches the parameter type
GoogleMapPoly; ensure any nearby doc tags (including the fromClient description)
remain accurate and consistent with the method signature.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 22a3bff6-c947-47a8-ab92-e06e5273877f
📒 Files selected for processing (2)
pom.xmlsrc/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoly.java
Member
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
paodb
approved these changes
Jun 11, 2026
github-project-automation
Bot
moved this from To Do
to Pending release
in Flowing Code Addons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #180
Summary by CodeRabbit
Chores
Improvements