Skip to content

fix: add compatible constructor for GoogleMapPolyClickEvent #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paodb merged 2 commits into from
Jun 11, 2026
Merged

fix: add compatible constructor for GoogleMapPolyClickEvent #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15153e0
fix: add compatible constructor for GoogleMapPolyClickEvent
javier-godoy Jun 10, 2026
47520d9
ci: add dance profile for cleanup
javier-godoy Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 52 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

<groupId>com.flowingcode.vaadin.addons</groupId>
<artifactId>google-maps</artifactId>
<version>2.4.1-SNAPSHOT</version>
<version>2.5.0-SNAPSHOT</version>
<name>Google Maps Addon</name>
<description>Integration of google-map for Vaadin platform</description>

Expand Down Expand Up @@ -555,7 +555,56 @@
</dependency>
</dependencies>
</profile>


<profile>
<id>dance</id>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-clean-plugin</artifactId>
<configuration>
<filesets>
<fileset>
<directory>${project.basedir}</directory>
<includes>
<include>package.json</include>
<include>package-lock.json</include>
<include>tsconfig.json</include>
<include>tsconfig.json.*</include>
<include>types.d.ts</include>
<include>types.d.ts.*</include>
<include>vite.config.ts</include>
<include>vite.generated.ts</include>
<include>webpack.config.js</include>
<include>webpack.generated.js</include>
</includes>
</fileset>
<fileset>
<directory>${project.basedir}/frontend</directory>
<includes>
<include>index.html</include>
</includes>
</fileset>
<fileset>
<directory>${project.basedir}/frontend/generated</directory>
</fileset>
<fileset>
<directory>${project.basedir}/node_modules</directory>
</fileset>
<fileset>
<directory>${project.basedir}/src/main/bundles</directory>
</fileset>
<fileset>
<directory>${project.basedir}/src/main/dev-bundle</directory>
</fileset>
</filesets>
</configuration>
</plugin>
</plugins>
</build>
</profile>

</profiles>

</project>
30 changes: 29 additions & 1 deletion src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoly.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,38 @@ public static class GoogleMapPolyClickEvent extends ClickEvent<GoogleMapPolygon>
private final double lat;
private final double lon;

/**
* Creates a new event with the click coordinates as separate lat/lon values.
*
* @param source the polygon that was clicked
* @param fromClient whether the event originated on the client side
* @param lat the latitude of the click
* @param lon the longitude of the click
*/
public GoogleMapPolyClickEvent(
GoogleMapPoly source,
boolean fromClient,
@EventData(value = "event.detail.latLng") JsonValue latLng) {
@EventData("event.detail.latLng.lat()") double lat,
@EventData("event.detail.latLng.lng()") double lon) {
super(source);
this.lat = lat;
this.lon = lon;
}

/**
* Creates a new event with the click coordinates as a JSON value.
*
* @param source the polygon that was clicked
* @param fromClient whether the event originated on the client side
* @param latLng a JSON object containing {@code lat} and {@code lng} properties
* @deprecated since 2.5.0, for removal. Use
* {@link #GoogleMapPolyClickEvent(GoogleMapPoly, boolean, double, double)} instead.
*/
@Deprecated
public GoogleMapPolyClickEvent(
GoogleMapPoly source,
boolean fromClient,
JsonValue latLng) {
super(source);
lat = ((JsonObject) latLng).getNumber("lat");
lon = ((JsonObject) latLng).getNumber("lng");
Expand Down
Loading