Skip to content

feat(components): gs-mutations-over-time: lazily load pages#1101

Merged
fengelniederhammer merged 34 commits intomainfrom
1093-mutations-over-time-lazy-loading
Apr 15, 2026
Merged

feat(components): gs-mutations-over-time: lazily load pages#1101
fengelniederhammer merged 34 commits intomainfrom
1093-mutations-over-time-lazy-loading

Conversation

@fengelniederhammer
Copy link
Copy Markdown
Collaborator

@fengelniederhammer fengelniederhammer commented Mar 23, 2026 •
edited
Loading

resolves #1093

Summary

This adds lazy loading to the gs-mutations-over-time. Data fetching is split into two phases:

  1. load the overall data, i.e. the columns (dates) and the rows (mutations) of the table
  2. fetch the page data based on which rows (mutations) should be shown

Pages are cached, we don't prefetch more that the current page. I don't know yet whether that would be worth the effort.

I also noted layout shifts while loading a page, but decided to split it out into a separate issue.
#1102

Screenshot

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 23, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dashboard-components Error Error Apr 14, 2026 8:04am

Request Review

@fengelniederhammer fengelniederhammer changed the title 1093 mutations over time lazy loading feat(components): gs-mutations-over-time: lazily load pages Mar 24, 2026
@fengelniederhammer fengelniederhammer marked this pull request as ready for review March 26, 2026 09:56
Copilot AI reviewed Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 31 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread components/src/preact/mutationsOverTime/mutations-over-time.tsx
Comment thread components/src/preact/shared/tanstackTable/pagination.tsx
Comment thread components/src/preact/mutationsOverTime/useMutationsOverTimePageData.ts
Comment thread components/src/preact/mutationsOverTime/useMutationsOverTimePageData.ts
fhennig
fhennig reviewed Apr 8, 2026
View reviewed changes
Comment thread components/src/preact/shared/tanstackTable/pagination.tsx Outdated
fhennig
fhennig reviewed Apr 9, 2026
View reviewed changes
Comment thread components/src/preact/mutationsOverTime/useMutationsOverTimePageData.ts
fhennig
fhennig requested changes Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Comment thread components/src/preact/mutationsOverTime/useMutationsOverTimePageData.ts
@fengelniederhammer fengelniederhammer merged commit 8128488 into main Apr 15, 2026
5 of 6 checks passed
@fengelniederhammer fengelniederhammer deleted the 1093-mutations-over-time-lazy-loading branch April 15, 2026 08:03
@github-actions github-actions bot mentioned this pull request Apr 15, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@fhennig fhennig fhennig approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mutations over time: lazy loading

3 participants

@fengelniederhammer @fhennig