Repository navigation
fix(providers): show save errors and flag model ids after an API format change - #175
Merged
Merged
Conversation
…at change - The provider form shows the server's error when a save is rejected and stays open, instead of a Save button that does nothing. - Model discovery returns 400 again when the upstream rejects the request (4xx) and 502 for other failures. - Changing the API format while the list has models shows a hint to fetch models again, since providers like OpenRouter return different ids per format.
GoDiao
force-pushed
the
fix/provider-form-errors
branch
from
October 24, 2026 19:37
2ce22d5 to
c29388f
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #159.
What changed
console.error, so Save looked like it did nothing. This was already the case on main.MODEL_DISCOVERY_FAILEDcode.nvidia/nemotron-3-ultra-550b-a55b:freefor OpenAI requests andanthropic/nvidia/nemotron-3-ultra-550b-a55b:free[1m]for Anthropic requests, and an id from one format fails with 400 in the other. The hint goes away after a successful fetch or when the format is changed back. The list itself is not changed.providers.jsoncan't be read by older versions and theproviders.json.bak-before-migration-*backup must be restored before downgrading.How it was tested
bun run lintand the desktop tests pass (1259 passed).bun test: 1357 passed; the 10 failures locally are the ripgrep-dependent tests, because ripgrep isn't on PATH on this machine. CI installs it.providers.json(OpenRouter): migration, editing and saving, model discovery in both formats, chatting with the OpenAI Chat and Anthropic formats, and the format-change hint.