Skip to content

chore: deploy-audit cleanup (drop fictional deploy.sh, fix CHANGELOG, add release workflow)#56

Merged
Patel230 merged 1 commit into
mainfrom
fix/deploy-audit-cleanup
Jun 10, 2026
Merged

chore: deploy-audit cleanup (drop fictional deploy.sh, fix CHANGELOG, add release workflow)#56
Patel230 merged 1 commit into
mainfrom
fix/deploy-audit-cleanup

Conversation

@Patel230

Copy link
Copy Markdown
Contributor

Why

A deploy-readiness audit on the hawk-eco set (hawk · eyrie · yaad · tok) surfaced a handful of files in this repo that referenced infrastructure that has never existed. This PR removes or repairs each. No production code is touched.

What changed

Removed

  • scripts/deploy.sh — referenced a Dockerfile, a deployments/kubernetes/tok-deployment.yaml manifest, an internal/integration/ test package, and a k6 load-test script that all never existed in this repo. tok is a Go library (AGENTS.md, .goreleaser.ymlbuilds.skip: true); deployment is go get.
  • /tokd line in .gitignore — the ./server HTTP daemon never shipped.

Fixed

  • CHANGELOG.md
    • Moved the 0.1.0 heading below [Unreleased] (Keep-a-Changelog ordering).
    • Stripped the backwards compare/v1.1.0...0.1.0 diff link.
    • Stopped claiming we re-baselined .release-please-manifest.json and scripts/install.sh — neither file exists.
    • The HTTP server mode (tokd) entry now documents that the daemon did not ship, consistent with the historical note in [0.29.0].
  • .github/workflows/ci.yml — pin gosec to v2.22.4 (was v2.21.4), matching every other gosec invocation in this workflow and across sibling repos.

Added

  • .github/workflows/release.yml — invokes goreleaser on a v* tag push. .goreleaser.yml already produces a source archive + SHA-256 checksums + SPDX SBOM (builds.skip: true), but nothing in CI was triggering it.

Validation

All run locally on Go 1.26.4 (matches go.mod):

Check Result
go build ./... clean
go vet ./... clean
gofumpt -l . clean
goimports -l . clean
golangci-lint run --timeout=5m 0 issues
go test ./... -short all pass
govulncheck ./... no vulnerabilities

Risk

Low. No source code in *.go files is modified.

Follow-ups (separate PRs)

The audit also found similar stale deploy/install scaffolding in eyrie, yaad, and hawk. Those will get their own PRs.

…, add release workflow

A deploy-readiness audit surfaced four stale/incorrect items in this repo;
this commit removes or repairs each.

Removed
-------
- scripts/deploy.sh — referenced a Dockerfile, a deployments/kubernetes/
  manifest, an internal/integration/ test package, and a k6 load-test
  script that never existed. tok is a Go library (AGENTS.md, .goreleaser.yml
  builds.skip: true); deployment is `go get`.
- /tokd entry in .gitignore — the ./server HTTP daemon never shipped.

Fixed
-----
- CHANGELOG.md:
  * 0.1.0 heading moved below [Unreleased] (Keep-a-Changelog ordering).
  * Stripped the backwards `compare/v1.1.0...0.1.0` diff link.
  * Stopped claiming we re-baselined `.release-please-manifest.json` and
    `scripts/install.sh` — neither file exists in this repo.
  * "HTTP server mode (tokd)" entry now documents that the daemon did not
    ship, matching the existing historical note under [0.29.0].
- .github/workflows/ci.yml: pin gosec to v2.22.4 (was v2.21.4), matching
  every other gosec invocation in the workflow + sibling repos.

Added
-----
- .github/workflows/release.yml: trigger goreleaser on `v*` tag pushes.
  The existing .goreleaser.yml builds source archives + SHA-256 checksums
  + SPDX SBOM (`builds.skip: true`) but had no workflow to invoke it.

Validation
----------
- go build ./... — clean
- go vet ./... — clean
- gofumpt -l . — clean
- goimports -l . — clean
- golangci-lint run --timeout=5m — 0 issues
- go test ./... -short — all pass
- govulncheck ./... — no vulnerabilities

@Patel230 Patel230 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review (cannot approve own PR): scope is documentation + workflow + a single removed deploy script; all 20 CI checks green incl. lint, race tests, govulncheck, gosec, codeql, trivy, dependency-review, fuzz, multi-OS build matrix. No Go source modified. Merging.

@Patel230

Copy link
Copy Markdown
Contributor Author

Self-review: scope is documentation + workflow + a single removed deploy script; all 20 CI checks green incl. lint, race tests, govulncheck, gosec, codeql, trivy, dependency-review, fuzz, multi-OS build matrix. No Go source modified. Merging.

@Patel230 Patel230 merged commit 138f7e4 into main Jun 10, 2026
20 checks passed
@Patel230 Patel230 deleted the fix/deploy-audit-cleanup branch June 10, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant