Repository navigation
knowledge: daily intake batch 20 - #171
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef363ebd63
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - 强制：pipeline import 与 `OMNI_PIPELINES` key、各 inventory 桶中的 `DOTS_TTS_*` / `DYNIN_*`，以及默认、CI、multiconnector deploy YAML 必须同时缺席。共享注释不得指向已删实现。 | ||
| - 禁止：只删模型代码却留下 key、env 名或 YAML；rebase 时恢复 `DOTS_TTS_PIPELINE` 或 `DYNIN_OMNI_PIPELINE`；再把已删除模型的旧 deploy pin 当作在运合同。 |
There was a problem hiding this comment.
When an agent handles dots.tts configuration, this mandatory-absence rule conflicts with CONF-3c in this same file at lines 179–184, which still requires preserving and testing the dots.tts pipeline and default deploy profile; models/catalog.md:105-124 also still lists both models and their pipeline keys as active. This leaves the current knowledge surface with mutually exclusive instructions, so retire or convert the old model rules/catalog entries to tombstones as part of this owner-scoped update before publishing the deletion gate.
AGENTS.md reference: AGENTS.md:L11-L17
Useful? React with 👍 / 👎.
| ## CONF-3e — 已删除的 dots.tts 与 Dynin-Omni 不得残留注册面 | ||
|
|
||
| - 触发：改 `pipeline_registry.py`、`environment_variable_inventory.py` 或 `vllm_omni/deploy/`，或试图恢复 `dots_tts` / `dynin_omni`。 |
There was a problem hiding this comment.
In Direct reviews, readers consume the compact owner routing map rather than scanning an entire rules page, but this batch updates neither nearest _index.md; the configuration page's own quick map also routes pipeline/deploy changes only to the older CONF-3a/4b/5a set. Consequently CONF-3e and DIST-1l will normally be skipped even for their stated triggers; add both rules to their owner routing/index entries in this batch.
AGENTS.md reference: AGENTS.md:L23-L24
Useful? React with 👍 / 👎.
Daily knowledge-intake batch from omni-reviewbot: executable rules distilled from merged PRs and copilot bugfix runs, append-only per the knowledge contract. Merging this PR is the human promotion gate — review the rules like any other knowledge edit.
Proposed rules
knowledge/repos/vllm-omni/components/distributed/rules.md→DIST-1l(sources: PR #7870)knowledge/repos/vllm-omni/components/configuration/rules.md→CONF-3e(sources: PR #7655)Source events
Public SDK curation result
{ "batch_id": "sha256:6576e04b3d21582d2767ddebab38dd6a3768b39a064de5d57aed121552d8ed6f", "success": true, "attempted": 2, "applied": 2, "accepted_indexes": [ 0, 1 ], "rejected_indexes": [], "updated_document_ids": [ "knowledge/repos/vllm-omni/components/configuration/rules.md", "knowledge/repos/vllm-omni/components/distributed/rules.md" ], "updated_on": "2026-09-20", "validators": [ { "validator_id": "knowledge/tools/check_knowledge_tree.py", "passed": true, "status": "passed", "returncode": 0, "output": "提醒：文件接近拆分线：general/review/guides/review-execution-contract.md (183 个非空行，21548 bytes)\n提醒：文件接近拆分线：repos/vllm-omni/ci/rules.md (243 个非空行，27775 bytes)\n提醒：文件接近拆分线：repos/vllm-omni/components/configuration/rules.md (179 个非空行，31137 bytes)\n提醒：目录有 15 个普通页面，应该考虑分类：repos/vllm-omni/components/configuration\n提醒：文件接近拆分线：repos/vllm-omni/components/diffusion/rules-attention.md (190 个非空行，25118 bytes)\n提醒：文件接近拆分线：repos/vllm-omni/components/diffusion/rules-checkpoint-loading.md (211 个非空行，26702 bytes)\n提醒：文件接近拆分线：repos/vllm-omni/components/diffusion/rules-output-lifecycle.md (147 个非空行，21047 bytes)\n提醒：文件接近拆分线：repos/vllm-omni/components/diffusion/rules-system-runtime.md (189 个非空行，27138 bytes)\n提醒：文件接近拆分线：repos/vllm-omni/components/diffusion/rules.md (172 个非空行，27612 bytes)\n提醒：目录有 22 个普通页面，应该考虑分类：repos/vllm-omni/components/diffusion\n提醒：文件接近拆分线：repos/vllm-omni/components/model-executor/rules-bridge-batch.md (134 个非空行，18619 bytes)\n提醒：文件接近拆分线：repos/vllm-omni/components/model-executor/rules.md (193 个非空行，31439 bytes)\n提醒：文件接近拆分线：repos/vllm-omni/components/scheduler/rules.md (299 个非空行，32496 bytes)\n提醒：文件接近拆分线：repos/vllm-omni/components/serving/rules-engine-lifecycle.md (246 个非空行，32271 bytes)\n提醒：文件接近拆分线：repos/vllm-omni/components/serving/rules.md (196 个非空行，31197 bytes)\n提醒：目录有 12 个普通页面，应该考虑分类：repos/vllm-omni/components/serving\n提醒：文件接近拆分线：repos/vllm-omni/models/hunyuan-image3/rules.md (137 个非空行，25387 bytes)\n提醒：文件接近拆分线：repos/vllm-omni/models/minicpm-o-4-5/rules.md (258 个非空行，30441 bytes)\n提醒：文件接近拆分线：repos/vllm-omni/models/minimax-h3/rules-cache-task.md (204 个非空行，28481 bytes)\n提醒：文件接近拆分线：repos/vllm-omni/models/minimax-h3/rules-deployment.md (236 个非空行，27707 bytes)\n提醒：文件接近拆分线：repos/vllm-omni/models/minimax-h3/rules.md (183 个非空行，32421 bytes)\n提醒：文件接近拆分线：repos/vllm-omni/models/qwen3-tts/rules.md (190 个非空行，20981 bytes)\n知识目录检查通过：0 个错误，22 个提醒" }, { "validator_id": "knowledge/tools/check_wiki_lint.py", "passed": true, "status": "passed", "returncode": 0, "output": "wiki lint 通过：0 个错误，0 个提醒（共 388 页）" } ], "rolled_back": false }The vllm-omni release audit runs in CI on this PR as usual.