Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion knowledge/repos/vllm-omni/components/configuration/rules.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: "vLLM-Omni 配置开发门禁"
created: 2026-07-16
updated: 2026-09-10
updated: 2026-09-20
type: rule
tags: [vllm-omni, components, config]
sources: ["claude-workflow-starter-private@296ea45", "PR #4281", "PR #5031", "PR #5073", "PR #5671", "PR #5678", "zuiho-kai/claude-workflow-starter@c217fc6", vllm_omni/config/model.py, vllm_omni/config/stage_config.py, vllm_omni/config/config_factory.py, vllm_omni/config/omni_config.py, vllm_omni/config/composable_parallel/, vllm_omni/deploy/qwen3_omni_moe.yaml, vllm_omni/engine/stage_init_utils.py, tests/config/test_config_factory.py, tests/engine/test_arg_utils.py, tests/engine/test_stage_engine_args.py, "PR #4795", "PR #5842", "PR #6082", "PR #6156", "PR #5741", "PR #6068", "PR #4765", "PR #5666", "PR #4222", "PR #5604", "PR #6293", "PR #6094", "vllm_omni/diffusion/data.py", "PR #6050", "PR #6322", "vllm_omni/config/pipeline_registry.py", "vllm_omni/diffusion/models/pi0_pipeline_config.py", "vllm_omni/diffusion/models/pi0/pipeline_pi0.py", "PR #5048", "PR #6458", "PR #6102", "PR #6308", "PR #6182", "PR #4820", "PR #6619", "PR #6680", "PR #6422", vllm_omni/deploy/higgs_multimodal_qwen3.yaml]
Expand Down Expand Up @@ -222,3 +222,10 @@ sources: ["claude-workflow-starter-private@296ea45", "PR #4281", "PR #5031", "PR
- 验收:覆盖有效非默认值的 CLI、deploy/structured 和 direct attention-config 路径,断言最终
`backend_kwargs`;覆盖错误 backend、非正值,以及 Top-K 超过 runtime block count 的回退。
`WanDMDPipeline` 一类 checkpoint alias 还必须由 `model_index.json` 自动发现。^[PR #4820]

## CONF-3e — 已删除的 dots.tts 与 Dynin-Omni 不得残留注册面

- 触发:改 `pipeline_registry.py`、`environment_variable_inventory.py` 或 `vllm_omni/deploy/`,或试图恢复 `dots_tts` / `dynin_omni`。
Comment on lines +226 to +228

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Route the appended rules through the owner maps

In Direct reviews, readers consume the compact owner routing map rather than scanning an entire rules page, but this batch updates neither nearest _index.md; the configuration page's own quick map also routes pipeline/deploy changes only to the older CONF-3a/4b/5a set. Consequently CONF-3e and DIST-1l will normally be skipped even for their stated triggers; add both rules to their owner routing/index entries in this batch.

AGENTS.md reference: AGENTS.md:L23-L24

Useful? React with 👍 / 👎.

- 强制:pipeline import 与 `OMNI_PIPELINES` key、各 inventory 桶中的 `DOTS_TTS_*` / `DYNIN_*`,以及默认、CI、multiconnector deploy YAML 必须同时缺席。共享注释不得指向已删实现。
- 禁止:只删模型代码却留下 key、env 名或 YAML;rebase 时恢复 `DOTS_TTS_PIPELINE` 或 `DYNIN_OMNI_PIPELINE`;再把已删除模型的旧 deploy pin 当作在运合同。
Comment on lines +229 to +230

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Reconcile the removed models with existing live rules

When an agent handles dots.tts configuration, this mandatory-absence rule conflicts with CONF-3c in this same file at lines 179–184, which still requires preserving and testing the dots.tts pipeline and default deploy profile; models/catalog.md:105-124 also still lists both models and their pipeline keys as active. This leaves the current knowledge surface with mutually exclusive instructions, so retire or convert the old model rules/catalog entries to tombstones as part of this owner-scoped update before publishing the deletion gate.

AGENTS.md reference: AGENTS.md:L11-L17

Useful? React with 👍 / 👎.

- 验收:registry 无这两项 key,deploy 目录无对应 YAML,inventory 无上述名称。^[PR #7655]
9 changes: 8 additions & 1 deletion knowledge/repos/vllm-omni/components/distributed/rules.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: "Distributed 传输规则"
created: 2026-08-05
updated: 2026-09-08
updated: 2026-09-20
type: rule
tags: [vllm-omni, components, distributed]
sources: ["PR #5744", "PR #5976", "PR #6001", "PR #6089", "PR #6834", vllm_omni/diffusion/distributed/parallel_state.py, tests/diffusion/distributed/test_expert_parallel_layout.py, vllm_omni/distributed/omni_connectors/adapter.py, vllm_omni/distributed/omni_connectors/kv_transfer_manager.py, vllm_omni/distributed/omni_connectors/transfer_adapter/chunk_transfer_adapter.py, vllm_omni/distributed/omni_connectors/transfer_adapter/base.py, vllm_omni/worker/omni_connector_model_runner_mixin.py, tests/distributed/omni_connectors/test_kv_recv_tp_consensus.py, tests/distributed/omni_connectors/test_chunk_transfer_adapter.py, tests/worker/test_omni_connector_mixin.py, "PR #5146", "PR #6021", "PR #6033", "PR #6360", "PR #6406", "PR #6626", "PR #6529", "PR #7136"]
Expand Down Expand Up @@ -142,3 +142,10 @@ confidence: high
- 强制:CUDA Mooncake 依赖必须钉在包含 acknowledged TCP writes 的版本(`0.3.12` 起);`batch_transfer_sync_write` 返回成功后,destination 内存必须已更新到可读状态,不能只表示本地 send 入队。回归必须在 receiver 被挂起时证明 completion 不会提前返回,恢复后再断言目的端字节一致。
- 禁止:降级到无 ACK 的 TCP 实现却不更新测试合同;把 RDMA 路径的 completion 语义外推到 TCP;或在 completion 前启动依赖 destination 内容的零拷贝消费。
- 验收:强制 TCP 的挂起-恢复测试覆盖「停止期间不完成、恢复后成功且字节匹配」;依赖声明与该测试同步变更。^[PR #7136]

## DIST-1l — NIXL 所有权测试必须用 reliable_claim_queries 隔离 claim 查询

- 触发:修改 NIXL connector 中断言 terminal 或 deferred read ownership、`_wait_for_transfer` 或 `entered.wait` 的测试,或改变 metadata claim 的获取方式。
- 强制:这类所有权用例必须挂上 `reliable_claim_queries`。fixture 仍覆盖 metadata 解析、wire 编解码、claim 生成和 producer claim 状态机,但不得用一次有界(10 ms)真实 ZMQ query 取得 claim。真实 ZMQ discovery 只由同模块 handshake 测试覆盖。
- 禁止:让所有权断言依赖 CI 下可能超时的短 query,使 `consumer.get()` 在进入 transfer wait 前返回;或放宽 `entered.wait` 来掩盖未挂 fixture。
- 验收:`direct` 与 `done`/`error`/`timeout`/`unknown` 在 fixture 下重复通过;所有权用例源码不再走有界 claim query。handshake 测试仍覆盖真实 ZMQ discovery。^[PR #7870]
Loading