Repository navigation
knowledge(vllm-omni): 1 change(s) from refine - #350
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 265b62034c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 重命名测试函数时必须同步 deselect 前缀与 contract。^[PR #8670] | ||
|
|
||
| <!-- kb:rule status=active since=v0.30.0 --> | ||
| <!-- kb:rule status=retired since=v0.30.0 retired_at=v0.30.0 reason=superseded evidence="PR #8751 diff：.buildkite/amd/test-amd-merge.yml 与 test-amd-ready.yml 各删除 temporal --deselect 行、仅保留 mimi 行；test-amd-nightly.yml 的 collect-only 与 run 命令都只剩 test_mimi_streaming_step_matches_legacy_end_to_end；tests/buildkite/test_amd_pipeline.py 同步更新；changed_files 含 tests/model_executor/models/personaplex/test_ring_per_row_offsets.py，其 diff 删除了 test_ring_slot_recycle_masks_old_history。PR body 明确：“#8670 added AMD pipeline steps that name the temporal parity test removed here. Those entries are dropped, and the Mimi streaming stress case keeps its nightly owner.” 且 “The ring-KV and RoPE primitives that Mimi uses stay in personaplex_temporal.py.”" superseded_by=VLLM-OMNI-PR8751-AMD-PPLEX-NIGHTLY --> |
There was a problem hiding this comment.
This evidence attribute persists a detailed diff replay and verbatim excerpts from the PR body inside the knowledge tree. Replace it with a concise source reference such as evidence="PR #8751"; repository policy requires raw PR material to remain temporary input outside the repository and be deleted after ingestion.
AGENTS.md reference: AGENTS.md:L12-L16
Useful? React with 👍 / 👎.
| ## VLLM-OMNI-PR8751-AMD-PPLEX-NIGHTLY — PersonaPlex Mimi 压力用例只在 AMD nightly 串行承接 | ||
|
|
||
| - 触发：改动 `.buildkite/amd/test-amd-ready.yml`、`.buildkite/amd/test-amd-merge.yml`、`.buildkite/amd/test-amd-nightly.yml` 的 Model Executor CPU shard 或 “Simple · PersonaPlex Temporal Streaming Test” 步骤；重命名或删除 `tests/model_executor/models/personaplex/test_temporal_streaming_hoist.py` 中的 `test_mimi_streaming_step_matches_legacy_end_to_end`；或修改 `tests/buildkite/test_amd_pipeline.py` 的 AMD pipeline contract。 | ||
| - 强制：AMD READY/MERGE 的 Model Executor 步骤保持 `-m 'core_model and cpu and not omni'` 与 `--num-shards=$$BUILDKITE_PARALLEL_JOB_COUNT`/`--shard-id=$$BUILDKITE_PARALLEL_JOB` 分片，只允许一条精确到 node 的 `--deselect` 前缀（`test_mimi_streaming_step_matches_legacy_end_to_end`），同文件其余快速节点继续留在阻塞 shard。被移出的 Mimi stress 用例由 nightly 的 PersonaPlex Temporal 步骤串行承接（collect-only、110m timeout、junitxml artifact）。三份 yml 与 `tests/buildkite/test_amd_pipeline.py` 断言的 contract 必须同步修改。 |
There was a problem hiding this comment.
Once the preceding rule is marked retired, Direct delivery hides it, but this successor retains only collect-only, the 110-minute timeout, and the JUnit artifact. It drops still-applicable safeguards including mi300_1, NonBlocking, the outer 120-minute timeout and kill grace, full log/summary artifacts, the retry/xdist prohibition, and the CUDA no-deselect requirement; PR #8751's stated deletion of only the temporal selection does not supersede those constraints. Carry them into the successor while changing only the selected test, as required by the repository's union-first merge policy.
AGENTS.md reference: AGENTS.md:L7-L11
Useful? React with 👍 / 👎.
Generated automatically by the Copilot knowledge service (changeset
vllm-omni-refine-ac1607d5ed81).repos/vllm-omni/models/personaplex/rules.mdGenerator:
zcode:GLM-5.3· judge:codex:gpt-6-sol:medium.The publisher merges it only if its local gate passes on the exact merge result.