Skip to content

knowledge(vllm-omni): 1 change(s) from refine #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tzhouam merged 1 commit into from
Oct 11, 2026
Merged

knowledge(vllm-omni): 1 change(s) from refine #350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions knowledge/repos/vllm-omni/models/personaplex/rules.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
---
title: "PersonaPlex 规则"
created: 2026-09-02
updated: 2026-10-09
updated: 2026-10-11
type: rule
tags: [vllm-omni, models, model-executor]
sources: ["PR #4771", "PR #6318", docs/design/fullduplex-personaplex.md, vllm_omni/model_executor/models/personaplex/duplex/serving_adapter.py, vllm_omni/model_executor/stage_input_processors/personaplex.py, tests/e2e/features/fullduplex/, tests/entrypoints/openai_api/test_duplex_handler.py, "PR #7399", "PR #7481", "PR #8670"]
sources: ["PR #4771", "PR #6318", docs/design/fullduplex-personaplex.md, vllm_omni/model_executor/models/personaplex/duplex/serving_adapter.py, vllm_omni/model_executor/stage_input_processors/personaplex.py, tests/e2e/features/fullduplex/, tests/entrypoints/openai_api/test_duplex_handler.py, "PR #7399", "PR #7481", "PR #8670", "PR #8751"]
confidence: high
---

Expand Down Expand Up @@ -139,4 +139,13 @@ confidence: high
两条前缀）与 nightly（选择同样前缀、NonBlocking、120/110 超时结构、预期 artifact 路径）；
重命名测试函数时必须同步 deselect 前缀与 contract。^[PR #8670]

<!-- kb:rule status=active since=v0.30.0 -->
<!-- kb:rule status=retired since=v0.30.0 retired_at=v0.30.0 reason=superseded evidence="PR #8751 diff：.buildkite/amd/test-amd-merge.yml 与 test-amd-ready.yml 各删除 temporal --deselect 行、仅保留 mimi 行；test-amd-nightly.yml 的 collect-only 与 run 命令都只剩 test_mimi_streaming_step_matches_legacy_end_to_end；tests/buildkite/test_amd_pipeline.py 同步更新；changed_files 含 tests/model_executor/models/personaplex/test_ring_per_row_offsets.py，其 diff 删除了 test_ring_slot_recycle_masks_old_history。PR body 明确：“#8670 added AMD pipeline steps that name the temporal parity test removed here. Those entries are dropped, and the Mimi streaming stress case keeps its nightly owner.” 且 “The ring-KV and RoPE primitives that Mimi uses stay in personaplex_temporal.py.”" superseded_by=VLLM-OMNI-PR8751-AMD-PPLEX-NIGHTLY -->

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove raw PR material from the lifecycle marker

This evidence attribute persists a detailed diff replay and verbatim excerpts from the PR body inside the knowledge tree. Replace it with a concise source reference such as evidence="PR #8751"; repository policy requires raw PR material to remain temporary input outside the repository and be deleted after ingestion.

AGENTS.md reference: AGENTS.md:L12-L16

Useful? React with 👍 / 👎.


## VLLM-OMNI-PR8751-AMD-PPLEX-NIGHTLY — PersonaPlex Mimi 压力用例只在 AMD nightly 串行承接

- 触发：改动 `.buildkite/amd/test-amd-ready.yml`、`.buildkite/amd/test-amd-merge.yml`、`.buildkite/amd/test-amd-nightly.yml` 的 Model Executor CPU shard 或 “Simple · PersonaPlex Temporal Streaming Test” 步骤；重命名或删除 `tests/model_executor/models/personaplex/test_temporal_streaming_hoist.py` 中的 `test_mimi_streaming_step_matches_legacy_end_to_end`；或修改 `tests/buildkite/test_amd_pipeline.py` 的 AMD pipeline contract。
- 强制：AMD READY/MERGE 的 Model Executor 步骤保持 `-m 'core_model and cpu and not omni'` 与 `--num-shards=$$BUILDKITE_PARALLEL_JOB_COUNT`/`--shard-id=$$BUILDKITE_PARALLEL_JOB` 分片，只允许一条精确到 node 的 `--deselect` 前缀（`test_mimi_streaming_step_matches_legacy_end_to_end`），同文件其余快速节点继续留在阻塞 shard。被移出的 Mimi stress 用例由 nightly 的 PersonaPlex Temporal 步骤串行承接（collect-only、110m timeout、junitxml artifact）。三份 yml 与 `tests/buildkite/test_amd_pipeline.py` 断言的 contract 必须同步修改。

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve the still-valid nightly safeguards

Once the preceding rule is marked retired, Direct delivery hides it, but this successor retains only collect-only, the 110-minute timeout, and the JUnit artifact. It drops still-applicable safeguards including mi300_1, NonBlocking, the outer 120-minute timeout and kill grace, full log/summary artifacts, the retry/xdist prohibition, and the CUDA no-deselect requirement; PR #8751's stated deletion of only the temporal selection does not supersede those constraints. Carry them into the successor while changing only the selected test, as required by the repository's union-first merge policy.

AGENTS.md reference: AGENTS.md:L7-L11

Useful? React with 👍 / 👎.

- 禁止：恢复 `test_temporal_streaming_step_matches_legacy_end_to_end` 的 `--deselect` 或 nightly 条目——该用例已随 dead temporal stepper（`PersonaPlexTemporalStreaming`/`_TemporalLayer`）在 PR #8751 删除；把 `--deselect` 放宽为文件级或通配前缀；只改 yml 不改 `test_amd_pipeline.py`（或反之）；因 stepper 已删而连带删除 `personaplex_temporal.py` 中 Mimi 仍消费的 ring-KV/RoPE 原语。
- 验收：READY/MERGE 只剩 Mimi 一条 `--deselect`；nightly 步骤的 collect 与 run 都只含 Mimi 用例；`tests/buildkite/test_amd_pipeline.py` 与三份 yml 当前内容一致并通过；`personaplex_temporal.py` 保留的 ring-KV/RoPE 原语仍由 `test_ring_per_row_offsets.py` 的存活用例覆盖——注意 PR #8751 同时删除了该文件中的 `test_ring_slot_recycle_masks_old_history`，不得把该文件的覆盖说成完全不变；原语的检查义务另受 PPLEX-HOIST-1a 约束。 ^[PR #8670] ^[PR #8751]

<!-- kb:rule status=active since=v0.30.0 supersedes=VLLM-OMNI-PR8670-AMD-PPLEX-NIGHTLY -->
Loading