Skip to content

knowledge(vllm-omni): 1 change(s) from refine - #357

Merged
tzhouam merged 1 commit into
mainfrom
kb/vllm-omni/vllm-omni-refine-6a23ee00f09c
Oct 12, 2026
Merged

tzhouam merged 1 commit into
mainfrom
kb/vllm-omni/vllm-omni-refine-6a23ee00f09c

Conversation

@tzhouam

@tzhouam tzhouam commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator

Generated automatically by the Copilot knowledge service (changeset vllm-omni-refine-6a23ee00f09c).

op page rule
add repos/vllm-omni/rules.md VLLM-OMNI-PR8770-NPU-RECORD-SHAPES

Generator: zcode:GLM-5.3 · judge: codex:gpt-6-sol:medium.
The publisher merges it only if its local gate passes on the exact merge result.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T15:41:25.602013Z 3118669 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tzhouam
tzhouam merged commit f1aa3a2 into main Oct 12, 2026
3 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3118669348

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


<!-- kb:rule status=active since=v0.30.0 -->

## VLLM-OMNI-PR8770-NPU-RECORD-SHAPES — NPU profiler 必须显式转发 torch_profiler_record_shapes

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Move the rule into the existing NPU-profiler owner page

The release baseline maps vllm_omni/platforms/ to the model-executor owner (adapters/vllm_omni/release_baseline.yaml:49-65), and components/model-executor/_index.md already routes NPU-profiler knowledge to rules-npu-profiler.md. Adding PR #8770 here splits one profiler contract across the repository catch-all and its established owner page, so owner-scoped review or later maintenance can update only one copy. Merge this rule and its source into the existing NPU-profiler page instead.

AGENTS.md reference: AGENTS.md:L12-L17

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant