Skip to content

knowledge(vllm-omni): 1 change(s) from refine #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tzhouam merged 1 commit into from
Oct 12, 2026
Merged

knowledge(vllm-omni): 1 change(s) from refine #357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion knowledge/repos/vllm-omni/rules.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ created: 2026-07-10
updated: 2026-10-12
type: rule
tags: [vllm-omni]
sources: [benchmark/incidents/_index.md, ci/incidents/_index.md, git/incidents/_index.md, remote/incidents/_index.md, "PR #8014", "PR #8786"]
sources: [benchmark/incidents/_index.md, ci/incidents/_index.md, git/incidents/_index.md, remote/incidents/_index.md, "PR #8014", "PR #8786", "PR #8770"]
---

# vLLM-Omni 硬门禁
Expand Down Expand Up @@ -116,3 +116,12 @@ sources: [benchmark/incidents/_index.md, ci/incidents/_index.md, git/incidents/_
- 验收：贡献者自查时，四个意图问题均有人类回答或公开安全引用并已回答“是否需要 PR”，bug fix 附可核验的失败证据（期望与实际行为、受影响修订版本与环境、最小复现/失败回归测试/失败 trace 之一）；改动四个文件的 PR 中，模板仍含四个带 `Required` 占位注释的小节，SKILL.md 含 `Contributor intent gate` 节，两份贡献文档指向 `#contributor-intent-gate` 的链接有效。^[PR #8786]

<!-- kb:rule status=active since=v0.30.0 -->

## VLLM-OMNI-PR8770-NPU-RECORD-SHAPES — NPU profiler 必须显式转发 torch_profiler_record_shapes

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Move the rule into the existing NPU-profiler owner page

The release baseline maps vllm_omni/platforms/ to the model-executor owner (adapters/vllm_omni/release_baseline.yaml:49-65), and components/model-executor/_index.md already routes NPU-profiler knowledge to rules-npu-profiler.md. Adding PR #8770 here splits one profiler contract across the repository catch-all and its established owner page, so owner-scoped review or later maintenance can update only one copy. Merge this rule and its source into the existing NPU-profiler page instead.

AGENTS.md reference: AGENTS.md:L12-L17

Useful? React with 👍 / 👎.


- 触发：改动 `vllm_omni/platforms/npu/profiler.py` 中 `NPUOmniProfiler._create_profiler` 传给 `torch_npu.profiler.profile(...)` 的参数集合，特别是 `record_shapes` 一项的取舍。
- 强制：该调用必须保留 `record_shapes=profiler_config.torch_profiler_record_shapes` 的显式转发。依据 PR #8770 随该行新增的代码注释：缺省此参数时 NPU profiler 会静默忽略 `torch_profiler_record_shapes=True`。
- 禁止：从 `_create_profiler` 删除 `record_shapes` 转发，或将其改为不读取 `profiler_config.torch_profiler_record_shapes` 的常量，使该配置项重新被静默忽略。
- 验收：`vllm_omni/platforms/npu/profiler.py` 的 `_create_profiler` 中，`torch_npu.profiler.profile(...)` 调用包含 `record_shapes=profiler_config.torch_profiler_record_shapes`。^[PR #8770]

<!-- kb:rule status=active since=v0.30.0 -->
Loading