Repository navigation
Add a Public231 fast-screen before full C1 - #181
Merged
Merged
Conversation
Smoke still comes first. A 60-request screen can drop a tip when both p50 and p95 are at least 2% or 0.5 ms worse than the current primary, so a clear regression does not spend a full three-round C1. KEEP stays on the full dual gate. Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com>
4 tasks done
A tip screen baseline is the primary SHA's own fast-screen of those request IDs. Typed percentiles and the StartLux 7.338/51.816 pooled pair are refused. A DROP records dropped_at. The screen-primary pair stays TBD until it is measured on those IDs. Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com>
Contract smoke of d2fab1e against Instant at 51f80ad passed 4/4. The 60-request screen primary did not: bucket 1024-2047 has 6 prompts and needs 8. Leave that pair TBD and do not substitute the full-C1 pooled numbers. The quota stays fail-closed. Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com>
A short bucket keeps every available prompt and records quota_shortfall. 2048+ below 16 is inconclusive and cannot early-DROP. Screen primary stays TBD. Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com>
hk2 screen p50 is 19.112976267933846 ms and p95 is 73.46072793006897 ms on 51f80ad. Full-C1 pooled 7.338/51.816 stays refused as a screen baseline. Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com>
hsliuustc0106
marked this pull request as ready for review
October 26, 2026 08:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required human contributor answers
Answer every question before implementation and PR submission, including drafts.
Reuse explicit, still-applicable human answers with a traceable source reference;
ask the human for anything missing and wait. An agent must not invent answers.
Blank fields, placeholders, or an agent-written rationale do not satisfy this gate.
Share only information and source links appropriate for this PR's audience.
What outcome are you trying to achieve?
Answer: Add a two-tier Public231 evaluation path so tips that clearly regress are dropped without a full C1, and record the measured StartLux Instant screen primary. Source: Hongsheng's authorizing task (2026-10-25), the 2026-10-26 WITHHOLD fix, InferRSI's quota decision, and the hk2 n=58 screen measurement the same day.
What is the highest-leverage variable for that outcome?
Answer: A fast-screen after smoke whose baseline is the primary SHA's own screen of the same request IDs on the same machine, never the full-C1 pooled pair. Quotas are 10/10/8/8/6/16 (58 when every bucket is full). A short bucket records
quota_shortfalland is not filled from another bucket. 2048+ below 16 is inconclusive and cannot early-DROP. Early DROP only when both of those screen percentiles are worse by ≥ +2% or ≥ +0.5 ms. Source: InferRSI protocol decision, system1 room 2026-10-26.How will this work move that variable rather than create busywork?
Answer: Document the rule in the existing skills and wire it through
benchmarks/bench.py --fast-screen/--baseline-screen, refusing typed pooled percentiles. Record the hk2 smoke PASS and the measured Instant screen primary below. Do not type those screen percentiles in place of--baseline-screen. Source: same decision and the hk2 measurement report.Who is the customer or user, and what do they actually need?
Answer: Maintainers and the InferRSI loop. They need a clear regression to stop before full C1, and KEEP to stay on the full dual gate. Source: Hongsheng authorized the update; InferRSI set the quotas; hk2 measured the screen primary.
After answering the four questions: is a PR needed at all to achieve this outcome?
Human decision and rationale (or explicit source reference): Yes. Open and keep draft PR #181. Do not mark ready and do not merge.
For a bug fix: link actual observed failure evidence.
Include the observed result of a minimal reproduction, failing regression test,
or relevant trace. Label untested diagnoses as unverified. For a non-bugfix,
state why this is not applicable.
Evidence: Not a bug fix. The numbers below are the operator-reported hk2 measurement. This commit does not remeasure them.
Purpose
Screen baseline is the same primary SHA, same machine, same request IDs. It is never a full-C1 pooled p50/p95.
--baseline-p50-msand--baseline-p95-msare refused. A full-C1 directory is refused. StartLux Instant pooled 7.338/51.816 (51f80ad681c8f7b1be9b22b5e700bef34e33534c) is refused as a screen baseline.Quotas are 0–127:10, 128–255:10, 256–511:8, 512–1023:8, 1024–2047:6 (was 8), 2048+:16. That is 58 requests when every bucket is full. Seed 231, one round, concurrency 1, warmup 5.
Cap-to-available: if a bucket has fewer prompts than its quota, take every prompt in that bucket and record
quota_shortfall. Do not fill from another bucket. Do not substitute another model's lengths. If 2048+ has fewer than 16, the whole screen isinconclusiveand cannot early-DROP.DROP only when both screen deltas are worse (
tip >= baseline * 1.02ortip >= baseline + 0.5ms) against that same-ID screen primary. A DROP writesdropped_at(YYYY-MM-DDTHH:MM:SSZ) infast_screen_drop.jsonand on the summary. KEEP is still only the full C1 dual gate.StartLux Instant screen primary (n=58, quotas 10/10/8/8/6/16), reported from hk2 and not remeasured here:
The measuring client was
923c8c739bcaf3cc2b098f3cf373c2b547d2666cplus a local-only patch that changed the 1024–2047 quota from 8 to 6. The remote tip may still have been on quota 8 when this was measured. This branch's committed runner samples n=58 with quota 6, so the next screen does not need that local patch. Artifacts on hk2:~/experiments/2026-10-26-pr181-screen-primary/screen-primary-n58/(SCREEN_PRIMARY.json,fast-screen/,screen_ids.json,local-quota-patch.diff).Do not type 19.112976267933846 / 73.46072793006897. Pass the saved run as
--baseline-screen. Do not write 7.338/51.816 as this screen primary.hk2 P2 contract smoke PASS, separate from the screen: client
d2fab1e08f231fe2e23540f3b25b2650cd416d09against StartLux Instant served at51f80ad681c8f7b1be9b22b5e700bef34e33534c, 4/4,evidence_completetrue. Artifacts:~/experiments/2026-10-26-pr181-screen-primary/primary/smoke/on hk2. That client has no StartLux or CUDA diff versus51f80ad. Offlinetests/benchmarkson that client: 109 OK. The 4/4 smoke is not the screen primary and not a latency pair.Clef and pplx-decider keep their full-C1 primaries in the recipes and the latency leaderboard. They do not inherit Instant's screen pair.
Test Plan
System1-Omni Version / Commit:
f675976db36167d0ec6911805990c184d21701c9oncursor/public231-fast-screen-3f8c, basea41e379453d4a8dc3cbe3f76c8754753c42230a1.python3 -m unittest discover -s tests/benchmarks -p 'test_*.py' -qNo new GPU run in this commit. The hk2 4/4 smoke and the n=58 screen primary are operator-reported.
Test Result
python3 -m unittest discover -s tests/benchmarks -p 'test_*.py' -q: 112 tests, OK. Typed 7.338/51.816 is still refused. A short bucket recordsquota_shortfall. 2048+ below 16 isinconclusiveand writes nodropped_at.d2fab1eversus Instant at51f80ad; screen primary n=58, p50 19.112976267933846 ms, p95 73.46072793006897 ms,evidence_completetrue, decisionscreen_primary,quota_shortfall{}.Demo / evidence
N/A as a new latency campaign. The screen primary and the smoke PASS are the operator-reported hk2 artifacts above. This PR stays draft.
Self-review
Before marking this PR ready for review or requesting maintainer review, complete
the self-review checklist.
Keep the PR in draft while this work is incomplete.
For agent assistance, use the optional precheck-pr skill.
Precheck notes: head
f675976db36167d0ec6911805990c184d21701c9. Screen primary is the reported n=58 pair. Do not mark ready.