Forbid long variable names that start with _#3784
Open
ShabbyX wants to merge 1 commit into
Open
Conversation
kenrussell
requested changes
Jul 17, 2026
kenrussell
left a comment
Member
There was a problem hiding this comment.
Thanks for revising this test. A few pieces of feedback:
- Please make the change against the top-of-tree conformance tests which are under
sdk/tests/rather than the older conformance suite snapshots underconformance-suites/. We can backport the change after it lands, but tend to keep the older snapshots running under both the old and the new behavior. - To make git logs easier to read and simplify rolls of the WebGL conformance suite into Chromium, please include details from the issue in the pull request's first message, and mention the Chromium issue number, even if it isn't publicly visible yet.
- Please add a new positive test like
shader-with-1022-character-identifier.frag.html. Add it to00_test_list.txtwith--min-version=2.0.1. Recent PRs where you can follow the pattern: #3785 and #3782 .
If any of this is too tedious let me know and I can help prepare the PR.
kenrussell
requested changes
Jul 17, 2026
kenrussell
left a comment
Member
There was a problem hiding this comment.
Could you please also modify specs/latest/2.0/index.html, https://registry.khronos.org/webgl/specs/latest/2.0/#5.3.1 , revising it to the new behavior? That way the spec and tests are in sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3783