Skip to content

Forbid long variable names that start with _ #3784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShabbyX wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Forbid long variable names that start with _ #3784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions conformance-suites/2.0.0/conformance2/glsl3/shader-with-1024-character-identifier.frag.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
}
</script>
<script id="fragmentShader_before" type="text/something-not-javascript">
// shader that uses 1024 character identifier that starts with underscore should succeed
// shader that uses 1024 character identifier that starts with underscore should fail
precision mediump float;
uniform float _a12345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012;
void main()
Expand Down Expand Up @@ -95,9 +95,9 @@
},
{
fShaderId: 'fragmentShader_before',
fShaderSuccess: true,
linkSuccess: true,
passMsg: 'shader with 1024 character identifier that starts with underscore should succeed'
fShaderSuccess: false,
linkSuccess: false,
passMsg: 'shader with 1024 character identifier that starts with underscore should fail'
},
{
fShaderId: 'fragmentShader_after',
Expand Down
Loading