Repository navigation
i18n: add German translation and locale detection - #541
Merged
KnifeLemon merged 4 commits intoOct 25, 2026
Merged
Conversation
KnifeLemon
approved these changes
Oct 25, 2026
KnifeLemon
left a comment
KnifeLemon
left a comment
Owner
There was a problem hiding this comment.
Thanks @deinzooshop, and welcome! A complete German catalog with the installer texts and automatic selection for de-* is great. Main moved since you started (European Portuguese and new strings), so this now conflicts and German is missing the newest keys. I'll merge main into your branch and translate those keys myself, so there's nothing for you to do. The engine-test failures you saw locally don't come from this change. German goes into the next release, and onto filee.sh too.
Main added European Portuguese (pt-PT) meanwhile. Both languages stay: German is matched before the shared Portuguese policy in LocalizationService.Resolve, and the Setup /LANG list names pt-PT and de. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- de.json gets the 23 keys main added since the PR started (built-in engine names and compact donut labels) and follows en.json's order. - de.lproj: Finder service title and permission explanations, listed in CFBundleLocalizations. - The READMEs list Deutsch among the UI languages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The pt-PT test used de-DE as an OS language Filee doesn't ship, which now selects German. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 25, 2026
cre8ive-marketing
added a commit
to cre8ive-marketing/Filee
that referenced
this pull request
Oct 25, 2026
cre8ive-marketing
added a commit
to cre8ive-marketing/Filee
that referenced
this pull request
Oct 25, 2026
cre8ive-marketing
added a commit
to cre8ive-marketing/Filee
that referenced
this pull request
Oct 25, 2026
…cimal MB From the review of KnifeLemon#567: - The queue checks every result against the preset's limit after the last step, and after a join, and refuses one that's over (HEIC, CAD and 3D renders, animations, pages, Remove metadata). The video field is hidden for joins, slideshows, VOB and DV. - Video: one encode, its bitrate capped (-maxrate / -bufsize) at what the length allows next to the CRF. The video is never copied as-is with a limit, and a second encode at a lower bitrate runs only if the first missed, on the last tenth of the progress bar. When nothing fits, it's refused before anything is encoded. - MB is 1,000,000 bytes (SizeLimit.Bytes), in the error detail too. - Pictures stop shrinking at a long edge of 640 px (or their own) and are refused there, never made a thumbnail. - The New menu is filled from PlacePresets; the "email 20" comment says 18. German strings for the new keys (KnifeLemon#541).
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds German (Deutsch) with all 1,106 current UI strings, including installer texts. German is available in the language picker and selected automatically for
deandde-*system cultures, including Germany, Austria and Switzerland.Type of change
How was it tested?
dotnet format Filee.slnx --verify-no-changes --no-restore --severity warnFilee.Setup.Testsproject: 160 passed.dotnet test Filee.slnx -c Release --no-restoreis green.The full suite was attempted on Windows and stopped after 13 engine-test failures and a LibreOffice export-cancellation timeout in an unchanged App integration test. The failures include OFD conversion, CAD-to-SVG XML, and LibreOffice formatting/repacking. Engine tests do not reference the changed App/Setup localization code. These failures have not been reproduced on an unmodified baseline. One initial Setup path check failed with
FILEE_DATA_DIRoverridden; the full Setup project passed after removing that override.Checklist
Screenshots
The German Home and General pages are rendered from this branch.