Repository navigation
Add slim accent scrollbar styles and themes for improved UI consistency - #568
adnan-bhaldar wants to merge 2 commits into
Conversation
|
Thanks @adnan-bhaldar for the work and the before/after screenshots. The change is tidy and stays inside We've decided to keep the current scrollbar, though, so I'm closing this one. A 6 px thumb is harder to grab than today's (the Thumb itself is only 6 px wide, so the rest of the column pages instead of dragging), and at rest the faded accent is hard to see: about 1.7:1 on the light page, where controls should reach 3:1. Making it easy to grab and clearly visible would bring it close to what's there now, so the change wouldn't buy much. The list and dropdown highlight fixes are worth having on their own. If you'd like, a small PR with just those (the selected row ending before the scrollbar, and rows inset inside the dropdown's rounded corners, keeping the Material You popup's shadow) is welcome. |
Then how about making the scroll bar thumb 8px or 10 px |
|
Thanks for following up! Width alone wouldn't change our decision, though: the current Fluent scrollbar already works well, and a wider pill that's also easy to grab and clearly visible ends up close to what's there now, so we'd rather not spend more time on the scrollbar. We'll keep it as it is. The list and dropdown fixes are still welcome as a separate small PR. |
Tip
Start the title with a prefix so the PR is labeled automatically:
feat:fix:docs:ci:build:i18n:Example:
fix(hwp): keep tables when converting to DOCXWhat does this change?
Replaces the classic Fluent scrollbar (arrow buttons, grey track, widens on hover) with a slim, accent-colored one, and fixes two spots where row highlights spilled out of their container. Only
src/Filee.App/Styles/Soft.axamlchanges.ListBox.soft, e.g. Presets): the scrollbar now has its own column instead of floating over the list, so the selected or hovered row ends before the scrollbar.ComboBox): rows are rounded and inset, so the selected or hovered row fits inside the rounded popup. The popup usesSoftRadiusand the rows useSoftRadiusSmall, so both follow the Softness setting, down to sharp corners.Type of change
How was it tested?
dotnet format --verify-no-changesdotnet testdotnet run --project src/Filee.App. Checked the scrollbar on the Presets list and the main page, hover and drag, and the Resize and Rotate dropdowns in the Presets editor.Not tested: macOS, Linux, the Windows installer (
Filee.Setuplinks the sameSoft.axaml, so it picks up the new scrollbar and dropdown styles too), and the Softness slider at every setting.Screenshots (UI changes)
Checklist
src/Filee.App/Assets/i18n/*.jsonfiles (no new strings)THIRD-PARTY-NOTICES.md(none added)