GitHub Issue 974: Lookup data type incorrectly shown in app assay designer#1971
Merged
cnathe merged 8 commits intorelease26.3-SNAPSHOTfrom Apr 6, 2026
Merged
GitHub Issue 974: Lookup data type incorrectly shown in app assay designer#1971cnathe merged 8 commits intorelease26.3-SNAPSHOTfrom
cnathe merged 8 commits intorelease26.3-SNAPSHOTfrom
Conversation
…even when premium module is not present - AssayDesignerPanels to pass appPropertiesOnly to AssayDomainForm - add new domainFormDisplayOptions.showAdvancedSettingsForApp for assay designer case
labkey-susanh
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
#974: LKSM: Lookup Data Type shown in Assay Designer
This PR fixes GitHub Issue #974, where the Lookup data type was incorrectly shown in the app assay designer even when the premium module was not present. The root cause was that AssayDesignerPanelsImpl was never actually
forwarding its appPropertiesOnly prop down to AssayDomainForm, so DomainForm always received undefined (falsy) for that prop — making it behave as if the app-property filter was off. The fix corrects the prop
forwarding, renames an intermediary prop for clarity, and adds a new showAdvancedSettingsForApp escape hatch that allows a downstream consumer (ui-premium) to re-enable the advanced settings button even in app mode.
Related Pull Requests
Changes