test: add Monaco editor e2e regression coverage#3505
Conversation
msmithstubbs
force-pushed
the
test/monaco-e2e-regression
branch
3 times, most recently
from
b2f7954 to
0da9c06
Compare
| assets/package-lock.json | ||
|
|
||
| - name: Install phoenix_test_jsdom Node dependencies | ||
| run: npm ci --prefix deps/phoenix_test_jsdom/priv |
There was a problem hiding this comment.
I think it would make sense for these to be separated out to an elixir-web-ci workflow that only triggers on change in the assets or logflare_web directory.
There was a problem hiding this comment.
Otherwise this essentially extends our CI for all changes even if its a minor change under the lib/logflare
There was a problem hiding this comment.
Alternatively we can do a specific jsdom tag for selectively running these tests
There was a problem hiding this comment.
I was thinking with caching the npm install step would have minimal impact. I'll put it in a separate workflow for now. Would be good to have a strategy for where the jsdom tests fit in between playwright and LIveViewTest.
There was a problem hiding this comment.
Another thought: we could hard code the list of events so it doesn't call node at compile time.
There was a problem hiding this comment.
i'll have another look at it next week 🤞 , removing it from compile time should be possible, can likely do it at packaging side...
i've merged in your cookie persistence PR btw will cut a release for it
There was a problem hiding this comment.
Would you like me to look into doing this? Or could move the JSDOM tests to a parallel PR? Be good to keep the monaco editor refactor moving forward.
msmithstubbs
force-pushed
the
test/monaco-e2e-regression
branch
6 times, most recently
from
7297c88 to
702b79b
Compare
msmithstubbs
force-pushed
the
test/monaco-e2e-regression
branch
from
702b79b to
bf7a595
Compare
2 participants
Adds baseline test for Monaco editor in preparation for refactor.
PR Stack
This is the first in a sequence of PRs that are intended to be merged in order.
See #3525
or search 🔍 is:pr O11Y-1543 sort:created-asc
Part of O11Y-1684 and O11Y-1543