feat: use new code editor component in QueryLive#3525
Draft
msmithstubbs wants to merge 4 commits into
Draft
Conversation
0c37b7f to
0ee7861
Compare
This was referenced May 26, 2026
67f637f to
6e5f08c
Compare
msmithstubbs
commented
May 29, 2026
Comment on lines
204
to
205
| socket.assigns.endpoints, | ||
| socket.assigns.alerts |
Contributor
Author
There was a problem hiding this comment.
Kept endpoints and alerts in assigns to match the current implementation but could just fetch them from Cache if it is fast enough.
7f5bbf2 to
35a396b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the LiveMonacoEditor component in QueryLive with our own component wrapper.
Key differences:
phx-*bindings to interact with the server.CleanShot.2026-05-29.at.15.01.51.mp4
Monaco editor is independent of LiveView
The key difference in this architecture is that the Monaco editor doesn't send update events to the live view process.
The Monaco editor updates a hidden textarea field and triggers a form-change event to the live view, matching the standard form-backed LiveView setup. The LiveView can update the form, and the Monaco editor will receive changes from the form field itself.
This simplifies the implementation and makes it much easier to test: we can test the Monaco DOM interactions with JS unit tests, and form interactions in LiveViewTest.
PR Stack
This is part of a sequence of PRs that are intended to be merged in order:
or search 🔍 is:pr O11Y-1543 sort:created-asc
Part of O11Y-1684 and O11Y-1543