test: silence BigQuery IAM/schema noise from background mocks#3550
Open
nelsonmestevao wants to merge 1 commit into
Open
test: silence BigQuery IAM/schema noise from background mocks#3550nelsonmestevao wants to merge 1 commit into
nelsonmestevao wants to merge 1 commit into
Conversation
nelsonmestevao
commented
Jun 2, 2026
| test "updates correctly" do | ||
| prev_config = Application.get_env(:logflare, Schema) | ||
| Application.put_env(:logflare, Schema, updates_per_minute: 1) | ||
| on_exit(fn -> Application.put_env(:logflare, Schema, prev_config) end) |
Contributor
Author
There was a problem hiding this comment.
Force updates_per_minute: 1 so the Schema throttle actually engages. With the test config's 900_000, the throttle window is ~0ms, so the second update raced past expect(:bigquery_tables_patch, 1) and crashed the GenServer. This way we avoid flakyness introduced by the crash.
nelsonmestevao
force-pushed
the
ne/mimic-mock-logs-bigquery
branch
from
c13fe35 to
fb434c5
Compare
nelsonmestevao
force-pushed
the
ne/mimic-mock-logs-bigquery
branch
8 times, most recently
from
97f869c to
1a05382
Compare
Tests were logging (and occasionally failing on) Mimic errors caused by BigQuery calls. By globally stubbing `BigQueryAdaptor` calls to update_iam_policy/0,1 and patch_dataset_access/1 we reduce the noise.
nelsonmestevao
force-pushed
the
ne/mimic-mock-logs-bigquery
branch
from
1a05382 to
e6bfab2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests were logging (and occasionally failing on) Mimic errors caused by BigQuery calls. By globally stubbing
BigQueryAdaptorcalls to update_iam_policy/0,1 and patch_dataset_access/1 we reduce the noise.