refactor(dependency): strip gated dead code, bump to v4.0.0#3
Closed
MahtraDR wants to merge 1 commit into
Closed
Conversation
Core lich 5.17.2+ provides ArgParser, SetupFiles, ScriptManager, map overrides, and DR startup natively via sentinel constants. All 7 gated blocks were dead code and have been removed (-1086 lines). Also removed: deprecated autostart stubs (no callers), one-shot Settings['autostart'] migration, redundant parse_args/display_args wrappers, and the fully dead boot sequence. What remains: preamble (version check, game guard) and runtime helpers (bankbot, slackbot, reportbot, hometown, verify_script) that dr-scripts still call and have not yet been upstreamed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4 tasks
Owner
Author
|
Retargeting to upstream elanthia-online/dr-scripts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Net: -1,952 lines (+84 / -2,036). dependency.lic is now ~110 lines.
What remains are runtime helpers (bankbot, slackbot, reportbot, hometown, verify_script, format_name) that dr-scripts still actively call. These are candidates for a future upstream into core lich.
Verification
All claims independently verified across all three repos (dr-scripts, gs-scripts, lich-5):
truein core (arg_parser.rb, setup_files.rb, global_defs.rb, map_base.rb, startup.rb)custom_requirecallers (gate.lic, performance-monitor.lic) confirmed safe -- both haverespond_to?(:start_scripts_if_available)guardsrespond_to?checks return false)Companion PR
autostart.lic cleanup (gs-scripts): removes legacy DR dependency path and
respond_to?guards that are now always true on 5.17.2+.Test plan
bundle exec rspec spec/dependency_spec.rb-- 43 examples, 0 failures🤖 Generated with Claude Code