chore(dev-deps): Bump vite to ^8.0.8 and vitest to ^4.1.4#305
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning MetaMask internal reviewing guidelines:
Ignoring alerts on:
|
|
@SocketSecurity ignore npm/detect-libc@2.1.2 Shell access expected. @SocketSecurity ignore npm/rolldown@1.0.0-rc.15 Network access is ok. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7233b34. Configure here.
| "vite": "^6.4.1", | ||
| "vitest": "^3.0.7" | ||
| "vite": "^8.0.8", | ||
| "vitest": "^4.1.4" |
There was a problem hiding this comment.
Stale @types/node version incompatible with new tools
Low Severity
Bumping vite to ^8.0.8 and vitest to ^4.1.4 introduces a peer dependency mismatch with @types/node at ^18.18. Previously, vite 6 accepted @types/node ^18.0.0 || ^20.0.0 || >=22.0.0, but vite 8 now requires ^20.19.0 || >=22.12.0 and vitest 4 requires ^20.0.0 || ^22.0.0 || >=24.0.0. While both are optional peer deps, the project's own engines field already targets ^20 || ^22 || >=24, so @types/node at ^18.18 is inconsistent with both the runtime target and the new tooling.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 7233b34. Configure here.
There was a problem hiding this comment.
Yes, we should probably change the version of @types/node to match node.engines at least. But we can worry about this later.


This bumps
viteandvitestto the latest versions to resolve an error in CI, where the latest versions in the previously allowed version range would introduce changes in the LavaMoatallowScriptsconfig.Note
Medium Risk
Upgrades core build/test tooling (
vitemajor bump andvitestmajor bump), which can change bundling and test execution behavior and may surface new CI/runtime issues.Overview
Updates dev tooling by upgrading
viteto^8.0.8andvitest/@vitest/coverage-istanbulto^4.1.4, with the correspondingyarn.lockrefresh (new/updated transitive deps such asrolldown,lightningcss, updatedchai, etc.).Adjusts the LavaMoat
allowScriptsconfiguration by removing thevite>esbuildoverride, leaving only theeslint-plugin-import-x>unrs-resolverentry.Reviewed by Cursor Bugbot for commit 7233b34. Bugbot is set up for automated code reviews on this repo. Configure here.