Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"@ts-bridge/cli": "^0.6.3",
"@types/node": "^18.18",
"@typescript-eslint/utils": "^8.6.0",
"@vitest/coverage-istanbul": "^3.0.7",
"@vitest/coverage-istanbul": "^4.1.4",
"@vitest/eslint-plugin": "^1.1.4",
"@yarnpkg/types": "^4.0.0-rc.52",
"depcheck": "^1.4.3",
Expand All @@ -75,8 +75,8 @@
"typedoc": "^0.26.11",
"typescript": "~5.7.3",
"typescript-eslint": "^8.48.1",
"vite": "^6.4.1",
"vitest": "^3.0.7"
"vite": "^8.0.8",
"vitest": "^4.1.4"
Comment thread
cursor[bot] marked this conversation as resolved.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale @types/node version incompatible with new tools

Low Severity

Bumping vite to ^8.0.8 and vitest to ^4.1.4 introduces a peer dependency mismatch with @types/node at ^18.18. Previously, vite 6 accepted @types/node ^18.0.0 || ^20.0.0 || >=22.0.0, but vite 8 now requires ^20.19.0 || >=22.12.0 and vitest 4 requires ^20.0.0 || ^22.0.0 || >=24.0.0. While both are optional peer deps, the project's own engines field already targets ^20 || ^22 || >=24, so @types/node at ^18.18 is inconsistent with both the runtime target and the new tooling.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 7233b34. Configure here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should probably change the version of @types/node to match node.engines at least. But we can worry about this later.

},
"packageManager": "yarn@4.10.3",
"engines": {
Expand Down
Loading
Loading