refactor: extract preflightChecks in AuthService login (#693)#817
Open
Peaostrel wants to merge 1 commit into
Open
refactor: extract preflightChecks in AuthService login (#693)#817Peaostrel wants to merge 1 commit into
Peaostrel wants to merge 1 commit into
Conversation
|
@Peaostrel Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #693
Description
The
loginmethod inAuthServicecontained a long sequence of checks making it difficult to understand the exact order and intent of the security pipeline at a glance.This PR refactors the login flow by extracting the initial security checks into a dedicated private
preflightChecksmethod. It also adds clear documentation regarding the ordering contract of the login process.Changes Made
logininto a newpreflightChecksprivate method.loginmethod only after preflight checks pass.