Skip to content

refactor: extract preflightChecks in AuthService login (#693) #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Peaostrel wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −1
Open

refactor: extract preflightChecks in AuthService login (#693) #817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/auth/auth.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,15 @@ export class AuthService {
};
}

async login(data: LoginDto, ipAddress?: string, userAgent?: string) {
/**
* Performs mandatory security checks before validating credentials.
*
* Ordering Contract:
* 1. Lockout check: Prevent any further action if account is temporarily locked.
* 2. CAPTCHA check: If failed attempts exceed threshold, require CAPTCHA to proceed.
* 3. Credentials check: (Performed in the main login method after preflight)
*/
private async preflightChecks(data: LoginDto): Promise<void> {
// Check if account is locked out
const isLocked = await this.rateLimitService.isAccountLocked(data.email);
if (isLocked) {
Expand All @@ -169,6 +177,10 @@ export class AuthService {
throw new UnauthorizedException('Invalid CAPTCHA');
}
}
}

async login(data: LoginDto, ipAddress?: string, userAgent?: string) {
await this.preflightChecks(data);

const user = await this.usersService.findByEmail(data.email);
if (!user) {
Expand Down
Loading