Repository navigation
Let microsandbox domain allows pass HTTPS - #894
Merged
Merged
Conversation
microsandbox's strict hostname mode, on by default, accepts a domain allow over TLS only with TLS interception. Every domain rule of a not-public egress (the model endpoint, restricted domains, public domains of the cap) therefore reset at the TLS handshake. Turn it off so these rules match by the guest's DNS answer and the TLS server name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On microsandbox, every sandbox whose egress is not fully public could not reach its model provider: the Turn failed with
connection_failed. Restricted domains failed the same way over HTTPS.Reproduced with the adapter's rule order and the v0.7.8 runtime: the SYN to the allowed domain's address passes, then the connection is reset after the ClientHello. The runtime logs
TCP egress denied by strict hostname policy sni="<allowed domain>". microsandbox'sstrictmode, on by default, accepts a domain allow over TLS only when TLS interception can inspect the authority.Change
The adapter sets
DisableStrict. Domain allows then match by the guest's DNS answer and the TLS server name. Group, address and default-deny rules are unchanged.Verification
Same rules, same runtime, before and after:
go vetand the adapter's network tests pass.Need help on this PR? Tag
@codesmith-botwith what you need.