fix: redact persisted manifests from job details#12
Merged
homerquan merged 1 commit intoMay 18, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Monitor.job_details/2, which exposed sensitive manifest contents (metadata, node configs, tool bindings, initial inputs) to API callers.GetJobsurface while preserving job metadata required for operator workflows.Description
public_job/1that removes the embedded"manifest"key from persisted job maps usingMap.drop/2.Monitor.job_details/2to returnpublic_job(job)instead of the raw persistedjob, preservingmanifest_refand other metadata.test "job details does not expose persisted embedded manifests"totests/e2e/monitor_test.exswhich persists a job with a synthetic secret-containingmanifestand asserts the manifest is not returned whilemanifest_refand summary remain available.Testing
mix formaton the modified files successfully (lib/mirror_neuron/monitor.exandtests/e2e/monitor_test.exs).elixirto parse the modified files successfully.mix deps.get/mix testbut it was blocked by the environment (Hex metadata download failed with HTTP 403), so full automated test execution could not complete in this environment.Codex Task