Skip to content

fix: redact persisted manifests from job details #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
homerquan merged 1 commit into from
May 18, 2026
+37 −1
Merged

fix: redact persisted manifests from job details #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/mirror_neuron/monitor.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ defmodule MirrorNeuron.Monitor do

{:ok,
%{
"job" => job,
"job" => public_job(job),
"summary" => summary,
"agents" => Enum.sort_by(agent_summaries, &{&1["assigned_node"], &1["agent_id"]}),
"recent_events" => recent_events(events, event_limit),
Expand All @@ -73,6 +73,10 @@ defmodule MirrorNeuron.Monitor do
end
end

defp public_job(job) do
Map.drop(job, ["manifest"])
end

def cluster_overview(opts \\ []) do
opts = Keyword.put_new(opts, :summary, :basic)

Expand Down
32 changes: 32 additions & 0 deletions tests/e2e/monitor_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,38 @@ defmodule MirrorNeuron.MonitorTest do
RedisStore.delete_job(job_id)
end

test "job details does not expose persisted embedded manifests" do
job_id = "monitor-secret-manifest-#{System.unique_integer([:positive])}"

RedisStore.persist_job(job_id, %{
"job_id" => job_id,
"graph_id" => "secret_demo",
"status" => "completed",
"submitted_at" => "2026-03-28T00:00:00Z",
"updated_at" => "2026-03-28T00:00:10Z",
"manifest" => %{
"metadata" => %{"api_key" => "MN_SECRET_TOKEN"},
"nodes" => [
%{
"node_id" => "worker",
"config" => %{"command" => "curl -H 'Authorization: Bearer MN_SECRET_TOKEN'"},
"tool_bindings" => [%{"token" => "MN_SECRET_TOKEN"}]
}
],
"initial_inputs" => %{"worker" => [%{"prompt" => "use MN_SECRET_TOKEN"}]}
},
"manifest_ref" => %{"graph_id" => "secret_demo"}
})

assert {:ok, details} = Monitor.job_details(job_id)

refute Map.has_key?(details["job"], "manifest")
assert details["job"]["manifest_ref"] == %{"graph_id" => "secret_demo"}
assert details["summary"]["job_id"] == job_id

RedisStore.delete_job(job_id)
end

test "job details reads only the requested recent event window" do
job_id = "monitor-event-window-#{System.unique_integer([:positive])}"

Expand Down
Loading