Skip to content

Having Consistent RainMelt Value for all Runoff Models: CFE#20

Merged
mkarim-rtx merged 2 commits into
developmentfrom
precip-out-mohammed
Mar 11, 2026
Merged

Having Consistent RainMelt Value for all Runoff Models: CFE#20
mkarim-rtx merged 2 commits into
developmentfrom
precip-out-mohammed

Conversation

@mkarim-rtx
Copy link
Copy Markdown

@mkarim-rtx mkarim-rtx commented Mar 7, 2026

Based on story: https://jira.nextgenwaterprediction.com/browse/NGWPC-9963.
Review and update as necessary the rainfall runoff models (CFE, LASAM, TOPMODEL, SAC-SMA) to assure they are generating consistent output of liquid water input in a consistent output variable that can be converted to appropriate units for display in ngenCERF

Coordinate as needed with MSWM configurations. 

Changes

Added output variable atmosphere_water__liquid_equivalent_precipitation_rate_out to pass input atmosphere_water__liquid_equivalent_precipitation_rate

Testing

https://confluence.nextgenwaterprediction.com/spaces/NGWPC/pages/90177659/RR+models+Consistent+rain+melt+Output#RRmodelsConsistentrain+meltOutput-CFE

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@mkarim-rtx mkarim-rtx marked this pull request as draft March 7, 2026 23:48
@mkarim-rtx mkarim-rtx changed the title added atmosphere_water__liquid_equivalent_precipitation_rate_out Having Consistent RainMelt Value for all Runoff Models: CFE Mar 10, 2026
@mkarim-rtx mkarim-rtx marked this pull request as ready for review March 10, 2026 18:47
Copy link
Copy Markdown

@zhengtaocui zhengtaocui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

@mkarim-rtx mkarim-rtx merged commit f904541 into development Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants