Skip to content

Having Consistent RainMelt Value for all Runoff Models: CFE #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkarim-rtx merged 2 commits into from
Mar 11, 2026
Merged

Having Consistent RainMelt Value for all Runoff Models: CFE #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39d2d02
added atmosphere_water__liquid_equivalent_precipitation_rate_out
mkarim-rtx Mar 7, 2026
50cd716
added atmosphere_water__liquid_equivalent_precipitation_rate_out as o…
mkarim-rtx Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion realizations/realization_cfe_pet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
"POTENTIAL_ET",
"ACTUAL_ET",
"SOIL_STORAGE",
"NWM_PONDED_DEPTH"
"NWM_PONDED_DEPTH",
"atmosphere_water__liquid_equivalent_precipitation_rate_out"
],
"modules": [
{
Expand Down
3 changes: 2 additions & 1 deletion realizations/realization_cfe_pet_surfnash.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
"POTENTIAL_ET",
"ACTUAL_ET",
"SOIL_STORAGE",
"NWM_PONDED_DEPTH"
"NWM_PONDED_DEPTH",
"atmosphere_water__liquid_equivalent_precipitation_rate_out"
],
"modules": [
{
Expand Down
25 changes: 20 additions & 5 deletions src/bmi_cfe.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#define CFE_DEBUG 0

#define INPUT_VAR_NAME_COUNT 5
#define OUTPUT_VAR_NAME_COUNT 15
#define OUTPUT_VAR_NAME_COUNT 16

#define STATE_VAR_NAME_COUNT 95 // must match var_info array size

Expand Down Expand Up @@ -206,7 +206,8 @@ static const char *output_var_names[OUTPUT_VAR_NAME_COUNT] = {
"SOIL_STORAGE",
"SOIL_STORAGE_CHANGE",
"SURF_RUNOFF_SCHEME",
"NWM_PONDED_DEPTH"
"NWM_PONDED_DEPTH",
"atmosphere_water__liquid_equivalent_precipitation_rate_out"
};

static const char *output_var_types[OUTPUT_VAR_NAME_COUNT] = {
Expand All @@ -224,6 +225,7 @@ static const char *output_var_types[OUTPUT_VAR_NAME_COUNT] = {
"double",
"double",
"int",
"double",
"double"
};

Expand All @@ -240,6 +242,7 @@ static const int output_var_item_count[OUTPUT_VAR_NAME_COUNT] = {
1,
1,
1,
1,
1,
1,
1
Expand All @@ -260,7 +263,8 @@ static const char *output_var_units[OUTPUT_VAR_NAME_COUNT] = {
"m",
"m",
"1",
"m"
"m",
"mm h-1"
};

static const int output_var_grids[OUTPUT_VAR_NAME_COUNT] = {
Expand All @@ -278,7 +282,8 @@ static const int output_var_grids[OUTPUT_VAR_NAME_COUNT] = {
0,
0,
0,
0
0,
0
};

static const char *output_var_locations[OUTPUT_VAR_NAME_COUNT] = {
Expand All @@ -296,7 +301,9 @@ static const char *output_var_locations[OUTPUT_VAR_NAME_COUNT] = {
"node",
"node",
"none",
"node"
"node",
"node"

};

// Don't forget to update Get_value/Get_value_at_indices (and setter) implementation if these are adjusted
Expand Down Expand Up @@ -2026,6 +2033,14 @@ static int Get_value_ptr (Bmi *self, const char *name, void **dest)
*dest = (void*)&cfe_ptr->nwm_ponded_depth_m;
return BMI_SUCCESS;
}

if (strcmp(name, "atmosphere_water__liquid_equivalent_precipitation_rate_out") == 0) {
cfe_state_struct *cfe_ptr;
cfe_ptr = (cfe_state_struct *) self->data;
*dest = (void*)&cfe_ptr->aorc.precip_kg_per_m2;
return BMI_SUCCESS;
}

/***********************************************************/
/*********** INPUT ***********************************/
/***********************************************************/
Expand Down