Skip to content

fix(release): render stack inventories that pin a chart released after the cut [self-managed 1.1] - #2988

Merged
kristinapathak merged 1 commit into
release-deploy/stacks/self-managed/v1.1from
kristinapathak/v1.1-maintenance-pins
Oct 29, 2026
Merged

kristinapathak merged 1 commit into
release-deploy/stacks/self-managed/v1.1from
kristinapathak/v1.1-maintenance-pins

Conversation

@kristinapathak

Copy link
Copy Markdown
Collaborator

TL;DR

Backport of #2974 to the self-managed 1.1 train. A patch on this train can pin a source chart version released after the train was cut. The stack inventory now accepts that chart tag when origin/main or the chart's maintenance branch contains it, so the patch still gets its inventory.

Additional Details

Why:

What changed:

This changes nothing under deploy/stacks/self-managed, so merging it does not cut a new stack patch. Not customer visible. No dependency changes.

For the Reviewer

For QA

  • go test ./... in tools/docs-version-sync: pass.
  • python3 tools/ci/test-github-release.py: pass (118 tests).
  • git diff --check: clean.
  • Ran the inventory's source chart step against the real deploy/stacks/self-managed/v1.1.0 tag (stack commit ad30a54ef):
    • With the tag's own pins (invocation 1.9.0, rate limiter 1.3.0, NATS auth callout 1.4.2): pass.
    • With invocation pinned to 1.6.2, which exists only on release-deploy/helm/http-invocation/v1.6: pass with this change (using the release from origin/release-deploy/helm/http-invocation/v1.6). Before it, it fails with is not an ancestor of stack commit ... or of its release snapshot source ....
  • The full inventory render was not run locally. It pulls the stack's other charts from the release chart registry, which only the release workflow can reach.
  • QA needed: no. Release tooling only.

Issues

Relates to #2972

Checklist

  • I am familiar with the Contributing Guidelines.
  • I have signed off my commits for Developer Certificate of Origin (DCO) compliance.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

🤖 Generated with Claude Code

…r the cut [self-managed 1.1]

Backport of #2974 to the self-managed 1.1 train.

A patch on this train can pin a source chart version released after
the train was cut, from main or from the chart's maintenance branch.
That tag is not an ancestor of the stack commit or of its snapshot
source, so the inventory rejected it. The inventory now also accepts a
chart tag that origin/main or origin/release-<tag prefix>X.Y contains.
Any other tag is still rejected.

tools/docs-version-sync now matches main. The docs keep only the
paragraphs this change adds; the Snapshot-Of paragraph from #2971 is
not on this branch.

Relates to #2972

Signed-off-by: Kristina Pathak <kpathak@nvidia.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kristinapathak kristinapathak self-assigned this Oct 28, 2026
@kristinapathak
kristinapathak requested review from a team as code owners October 28, 2026 19:04
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review: 1
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

@kristinapathak
kristinapathak merged commit bd8d944 into release-deploy/stacks/self-managed/v1.1 Oct 29, 2026
30 checks passed
@kristinapathak
kristinapathak deleted the kristinapathak/v1.1-maintenance-pins branch October 29, 2026 16:09
@balajinvda

Copy link
Copy Markdown
Contributor

This PR is included in version 1.1.1.

The release is available on GitHub release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants