Repository navigation
fix(release): render stack inventories that pin a chart released after the cut [self-managed 1.1] - #2988
Merged
kristinapathak merged 1 commit intoOct 29, 2026
Conversation
…r the cut [self-managed 1.1] Backport of #2974 to the self-managed 1.1 train. A patch on this train can pin a source chart version released after the train was cut, from main or from the chart's maintenance branch. That tag is not an ancestor of the stack commit or of its snapshot source, so the inventory rejected it. The inventory now also accepts a chart tag that origin/main or origin/release-<tag prefix>X.Y contains. Any other tag is still rejected. tools/docs-version-sync now matches main. The docs keep only the paragraphs this change adds; the Snapshot-Of paragraph from #2971 is not on this branch. Relates to #2972 Signed-off-by: Kristina Pathak <kpathak@nvidia.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 1
Please check the settings in the CodeRabbit UI or the
|
Contributor
balajinvda
approved these changes
Oct 29, 2026
Closed
3 of 4 tasks
kristinapathak
merged commit Oct 29, 2026
bd8d944
into
release-deploy/stacks/self-managed/v1.1
30 checks passed
Contributor
|
This PR is included in version 1.1.1. The release is available on GitHub release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Backport of #2974 to the self-managed 1.1 train. A patch on this train can pin a source chart version released after the train was cut. The stack inventory now accepts that chart tag when
origin/mainor the chart's maintenance branch contains it, so the patch still gets its inventory.Additional Details
Why:
mainor from a chart maintenance branch such asrelease-deploy/helm/http-invocation/v1.6. That tag is outside both histories, so the inventory fails. See ci(release): stack inventory rejects a patch that pins a chart released after the branch cut #2972.tools/docs-version-syncfrom the tagged commit, so the fix onmaindoes not reach tags on this branch.What changed:
docs-version-syncaccepts it whenorigin/mainororigin/release-<tag prefix>X.Yfor the tag's minor contains it. It logs that branch to stderr.tools/docs-version-syncnow matchesmainexactly.docs/dev/github-release-process.mdgets the two paragraphs from fix(release): render stack inventories that pin a chart released after the cut #2974. TheSnapshot-Ofparagraph next to the second one came from fix(release): open stack trains with a mergeable bump and an inventory #2971 and is not on this branch, so it is not added here.This changes nothing under
deploy/stacks/self-managed, so merging it does not cut a new stack patch. Not customer visible. No dependency changes.For the Reviewer
git diff origin/main -- tools/docs-version-syncis empty on this branch.For QA
go test ./...intools/docs-version-sync: pass.python3 tools/ci/test-github-release.py: pass (118 tests).git diff --check: clean.deploy/stacks/self-managed/v1.1.0tag (stack commitad30a54ef):release-deploy/helm/http-invocation/v1.6: pass with this change (using the release from origin/release-deploy/helm/http-invocation/v1.6). Before it, it fails withis not an ancestor of stack commit ... or of its release snapshot source ....Issues
Relates to #2972
Checklist
🤖 Generated with Claude Code