Repository navigation
feat(api-keys): add v2 key owner, account admin and platform admin controllers - #2993
Draft
shelleyshen-0 wants to merge 1 commit into
Draft
shelleyshen-0 wants to merge 1 commit into
shelleyshen-0 wants to merge 1 commit into
Conversation
…ntrollers Expose the shared key management facade under /v2/api-keys/key-owner, /v2/api-keys/account-admin and /v2/api-keys/platform-admin. Each controller maps its routes to facade calls with its actor, and the NCA, issuer service and user come from the route. Integration tests cover each actor over HTTP. Signed-off-by: Shelley Shen <shelleys@nvidia.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Adds the REST controllers for the three v2 actors over the shared key management facade from #2840. Draft, stacked on that PR.
Additional Details (optional for docs, build, test, refactor, ci, chore, style, and revert PRs)
Each controller only maps routes to
KeyManagementFacadecalls with itsKeyManagementActor. The NCA, issuer service and user always come from the route.KeyOwnerKeysControllerunder/v2/api-keys/key-owner.AccountAdminKeysControllerunder/v2/api-keys/account-admin.PlatformAdminKeysControllerunder/v2/api-keys/platform-admin.The controllers follow the existing controller style: literal paths in the mappings, private constants only for path variable names, and
@Parameterdescriptions on path variables.This PR targets
feat/api-keys-v2-common-layer, not the release branch, so the diff shows only the controllers. It should be retargeted after #2840 merges.Not included: actor audit logging, the key count limit, and bulk operations.
For the Reviewer
Compare the three controllers for which routes each actor exposes. Account Admin has no cross-account statuses route, and only Platform Admin can update an issuer-service status.
For QA (optional for docs, build, test, refactor, ci, chore, style, and revert PRs)
Integration tests cover each actor over HTTP.
bazel test //src/control-plane-services/api-keys:testspasses on this code. QA is not needed yet.Issues
Relates to #2058
Relates to #2057
Relates to #2056
Checklist