Fix handling of CUDA Compat header on Orin systems#1804
Merged
Conversation
This change truncates the libraries used to test the processing of the CUDA compat elf header to avoid adding files that are ~90MB in size. Signed-off-by: Evan Lezar <elezar@nvidia.com>
This change adds a unit test to reprocude the out-of-bounds access when processing a libcuda.so orin compat library. Signed-off-by: Evan Lezar <elezar@nvidia.com>
This change fixes the handling of the CUDA compat ELF header on Orin systems. The padding of the header was such that the existing implementation would cause an out of bounds error when processing the relevant ELF note. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
repro-orin-out-of-bounds
branch
from
a9e2d67 to
1a09d4a
Compare
elezar
changed the title
Coverage Report for CI Build 25718833415Coverage increased (+0.009%) to 43.335%Details
Uncovered Changes
Coverage Regressions31 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
Member
Author
|
/cherry-pick release-1.19 |
cdesiniotis
approved these changes
May 12, 2026
Contributor
cdesiniotis
left a comment
cdesiniotis
left a comment
There was a problem hiding this comment.
Thanks @elezar! CI failure is known and is unrelated to this PR (is fixed on main already).
|
🤖 Backport PR created for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Orin systems, the CUDA compat header included in libcuda.so in the container has two problems:
This PR makes the following changes:
Note that the libraries used as test data have been truncated to only include the relevant notes.