Skip to content

[release-1.19] Fix handling of CUDA Compat header on Orin systems#1822

Merged
cdesiniotis merged 4 commits into
release-1.19from
backport-1804-to-release-1.19
May 12, 2026
Merged

[release-1.19] Fix handling of CUDA Compat header on Orin systems#1822
cdesiniotis merged 4 commits into
release-1.19from
backport-1804-to-release-1.19

Conversation

@github-actions
Copy link
Copy Markdown

🤖 Automated backport of #1804 to release-1.19

✅ Cherry-pick completed successfully with no conflicts.

Original PR: #1804
Original Author: @elezar

Cherry-picked commits (3):

  • b784265 testdata: truncate libcuda compat fixtures
  • 5dfc803 test: Reproduce orin compat check error
  • 1a09d4a fix(cudacompat): Fix handling of CUDA compat on Orin

This backport was automatically created by the backport bot.

elezar added 3 commits May 12, 2026 17:29
This change truncates the libraries used to test the processing of the
CUDA compat elf header to avoid adding files that are ~90MB in size.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
(cherry picked from commit b784265)
This change adds a unit test to reprocude the out-of-bounds access
when processing a libcuda.so orin compat library.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
(cherry picked from commit 5dfc803)
This change fixes the handling of the CUDA compat ELF header on Orin
systems. The padding of the header was such that the existing implementation
would cause an out of bounds error when processing the relevant ELF note.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
(cherry picked from commit 1a09d4a)
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 12, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
@coveralls
Copy link
Copy Markdown

coveralls commented May 12, 2026

Coverage Report for CI Build 25751531839

Coverage increased (+0.02%) to 43.341%

Details

  • Coverage increased (+0.02%) from the base build.
  • Patch coverage: 2 uncovered changes across 1 file (5 of 7 lines covered, 71.43%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
cmd/nvidia-cdi-hook/cudacompat/cuda-elf-header.go 7 5 71.43%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 14866
Covered Lines: 6443
Line Coverage: 43.34%
Coverage Strength: 0.48 hits per line

💛 - Coveralls

@cdesiniotis
Copy link
Copy Markdown
Contributor

/ok to test 5e20c0d

@cdesiniotis cdesiniotis enabled auto-merge May 12, 2026 17:38
@cdesiniotis cdesiniotis merged commit f3d822e into release-1.19 May 12, 2026
20 checks passed
@cdesiniotis cdesiniotis deleted the backport-1804-to-release-1.19 branch May 12, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants