Fix release: build release-assets and publish via gh CLI#59
Merged
Conversation
Assets attached to a GitHub release: the branding guide plus the public media-kit logos, flattened into one buildable package. Restores the content of the removed nixos-media-kit (b1e12e2) combined with the guide, excluding the internal logos and the index.html files that deployed-assets generates for the Netlify web deploy.
The release job built .#nixos-branding.nixos-media-kit, which was removed in b1e12e2, so the release workflow has been broken at "Build Media Kit" since. Build the new release-assets package instead (guide + public logos in one derivation) and upload its contents. Also replace softprops/action-gh-release with the pre-installed gh CLI (clears zizmor superfluous-actions), removing third-party code from the contents:write release job. gh release create fails if the release already exists and if a file glob matches nothing, which is the intended behavior: no accidental overwrite of an existing release, and fail loudly on a missing artifact.
Artifact comparison0 modified · 0 added · 0 deleted · 96 unchanged Download report — HTML file; open in a browser. Compared
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the release workflow and finishes the zizmor cleanup, in one PR:
release-assetspackage — one derivation bundling the branding guide PDF + the public media-kit logos, flattened. Restores the content of thenixos-media-kitpackage (removed inb1e12e2) combined with the guide.release-assets(one build step instead of two) and publishes withgh release createinstead ofsoftprops/action-gh-release.Why
.#nixos-branding.nixos-media-kit, which was removed inb1e12e2("nixos-branding.nixos-media-kit: remove"). That attribute no longer exists, so the release workflow has been broken at "Build Media Kit" ever since — this restores a working release.superfluous-actionsfinding and removes third-party code from thecontents: writerelease job.gh release createfails if the release already exists (no accidental overwrite) and fails if a file glob matches nothing (fail loudly on a missing artifact) — both are the behavior we want.Parity
Release-asset content is unchanged from before the media-kit removal: the guide PDF + the 52 public logos, flat. Verified by building
release-assetsand diffing its file set againstdeployed-assets— identical todocuments+logos, excludinginternalsand the generatedindex.html.Verification
release-assets: guide PDF + 52 public logo SVGsnix flake check: passactionlint: cleanzizmor:superfluous-actionscleared. The only remaining findings are theexcessive-permissionsset (the separate permissions-hardening PR).Note
gh release createfails if a release for the tag already exists (intentional — avoids overwriting a published release). A re-run after a partial failure requires deleting the release first.