feat: upgrade Node.js to 24.14.0 and ws-worker to 1.23.3 + database name env hooks for local dev#4603
Open
feat: upgrade Node.js to 24.14.0 and ws-worker to 1.23.3 + database name env hooks for local dev#4603
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4603 +/- ##
==========================================
+ Coverage 89.50% 89.51% +0.01%
==========================================
Files 441 441
Lines 21295 21295
==========================================
+ Hits 19060 19063 +3
+ Misses 2235 2232 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
josephjclark
approved these changes
Apr 7, 2026
- Bump Node.js from 22.12.0 to 24.14.0 across .tool-versions, Dockerfiles, and CircleCI config - Bump @openfn/ws-worker to 1.23.3 (includes @openfn/runtime 1.9.0 with ESM resolve hook for Node 24 strict module resolution) - Update @types/node and @tsconfig/node-lts to v24 - Make dev/test database names configurable via DEV_DATABASE_NAME and TEST_DATABASE_NAME env vars - Update integration test version assertion to match Node 24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades Node.js from 22.12.0 to 24.14.0 (matching the kit repo) and
bumps ws-worker to 1.23.3, which includes @openfn/runtime 1.9.0 with an ESM
resolve hook required for Node 24's stricter module resolution.
Also makes dev/test database names configurable via
DEV_DATABASE_NAMEandTEST_DATABASE_NAMEenvironment variables (defaulting to the existing names).This is useful when working on multiple checkouts or related repos (e.g.
lightning and thunderbolt) simultaneously, allowing each to use separate
databases without conflicts. Without this, developers need to pass
DATABASE_URLon every command or risk collisions between repos sharing thesame Postgres instance.
Validation steps
mix test test/integration/web_and_worker_test.exs— confirms ws-workerexecutes jobs correctly under Node 24
npm testinassets/— all 2569 frontend tests passARG NODE_VERSION=24.14.0Additional notes for the reviewer
.jsextensions for subpathimports). The fix is in @openfn/runtime 1.9.0 (bundled with ws-worker 1.23.3)
which registers a custom ESM resolve hook to handle this transparently.
@tsconfig/node-ltsand@types/nodepackages were bumped to v24.DEV_DATABASE_NAME,TEST_DATABASE_NAME) areopt-in — defaults are unchanged, so no impact on existing setups. Pair with a
.envrc(gitignored) and direnv for a seamless per-checkout experience.AI Usage
Pre-submission checklist