Skip to content

feat: upgrade Node.js to 24.14.0 and ws-worker to 1.23.3 + database name env hooks for local dev#4603

Open
stuartc wants to merge 2 commits intomainfrom
node-24-upgrade
Open

feat: upgrade Node.js to 24.14.0 and ws-worker to 1.23.3 + database name env hooks for local dev#4603
stuartc wants to merge 2 commits intomainfrom
node-24-upgrade

Conversation

@stuartc
Copy link
Copy Markdown
Member

@stuartc stuartc commented Apr 7, 2026

Description

This PR upgrades Node.js from 22.12.0 to 24.14.0 (matching the kit repo) and
bumps ws-worker to 1.23.3, which includes @openfn/runtime 1.9.0 with an ESM
resolve hook required for Node 24's stricter module resolution.

Also makes dev/test database names configurable via DEV_DATABASE_NAME and
TEST_DATABASE_NAME environment variables (defaulting to the existing names).
This is useful when working on multiple checkouts or related repos (e.g.
lightning and thunderbolt) simultaneously, allowing each to use separate
databases without conflicts. Without this, developers need to pass
DATABASE_URL on every command or risk collisions between repos sharing the
same Postgres instance.

Validation steps

  1. Verify CI passes with Node 24.14.0
  2. Run mix test test/integration/web_and_worker_test.exs — confirms ws-worker
    executes jobs correctly under Node 24
  3. Run npm test in assets/ — all 2569 frontend tests pass
  4. Verify Docker builds succeed with ARG NODE_VERSION=24.14.0

Additional notes for the reviewer

  1. Node 24 enforces strict ESM resolution (requires .js extensions for subpath
    imports). The fix is in @openfn/runtime 1.9.0 (bundled with ws-worker 1.23.3)
    which registers a custom ESM resolve hook to handle this transparently.
  2. The @tsconfig/node-lts and @types/node packages were bumped to v24.
  3. The database name env vars (DEV_DATABASE_NAME, TEST_DATABASE_NAME) are
    opt-in — defaults are unchanged, so no impact on existing setups. Pair with a
    .envrc (gitignored) and direnv for a seamless per-checkout experience.

AI Usage

  • I have used Claude Code
  • I have used another model
  • I have not used AI

Pre-submission checklist

  • I have performed an AI review of my code
  • I have implemented and tested all related authorization policies.
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

@github-project-automation github-project-automation bot moved this to New Issues in Core Apr 7, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.51%. Comparing base (bf0687f) to head (9f052d5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4603      +/-   ##
==========================================
+ Coverage   89.50%   89.51%   +0.01%     
==========================================
  Files         441      441              
  Lines       21295    21295              
==========================================
+ Hits        19060    19063       +3     
+ Misses       2235     2232       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Bump Node.js from 22.12.0 to 24.14.0 across .tool-versions,
  Dockerfiles, and CircleCI config
- Bump @openfn/ws-worker to 1.23.3 (includes @openfn/runtime 1.9.0
  with ESM resolve hook for Node 24 strict module resolution)
- Update @types/node and @tsconfig/node-lts to v24
- Make dev/test database names configurable via DEV_DATABASE_NAME
  and TEST_DATABASE_NAME env vars
- Update integration test version assertion to match Node 24
@stuartc stuartc changed the title feat: upgrade Node.js to 24.14.0 and ws-worker to 1.23.3 feat: upgrade Node.js to 24.14.0 and ws-worker to 1.23.3 + database name env hooks for local dev Apr 7, 2026
@stuartc stuartc moved this from New Issues to In review in Core Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

2 participants