Open
Conversation
taylordowns2000
commented
Apr 9, 2026
| } else { | ||
| // Fallback: navigate away if no callback (for standalone mode) | ||
| // Don't reset isSubmitting - the page is redirecting and resetting would cause a flash | ||
| window.location.href = `/projects/${projectId}/runs/${response.data.run_id}`; |
Member
Author
There was a problem hiding this comment.
this is the change - don't redirect away from the canvas!
taylordowns2000
commented
Apr 9, 2026
| } else { | ||
| // Fallback: navigate to new run (component will unmount) | ||
| // Don't reset isSubmitting - the page is redirecting and resetting would cause a flash | ||
| window.location.href = `/projects/${projectId}/runs/${result.data.run_id}`; |
Member
Author
There was a problem hiding this comment.
same here - don't redirect!
Security ReviewClaude hit the max-turns limit or encountered an error before posting findings. See the workflow run for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the workflow canvas to stay on the page after clicking "Run" or "Retry" instead of redirecting to the history page. It also tracks the run ID in the URL (?run=...) so the run selection persists, adds a fallback to the history store's active run when LiveView strips the client-side URL param, and gives in-progress steps a blue highlight on the canvas (matching the "running" chip color in the mini history panel).
Closes #4198
Validation steps
Additional notes for the reviewer
isRetryingRefbug was a missing reset in the else branch (canvas flow) ofhandleRetry— theonRunSubmittedpath reset it via thependingRunIdeffect, but the no-callback path never did.styles.test.ts(node colors),CollaborativeWorkflowDiagram.url-fallback.test.tsx(URL resilience), plus 4 new tests inuseRunRetry.test.tsx(canvas flow + regression).AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)