-
Notifications
You must be signed in to change notification settings - Fork 71
Don't redirect to runs page after clicking run #4608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0fdfe86
dont redirect, close #4198
taylordowns2000 67db63e
moar
taylordowns2000 454acfc
fix #4198
taylordowns2000 8e73192
review: prevent loops via restoredRunRef
taylordowns2000 a3dd253
fix: mocks
doc-han b923a63
Merge branch 'main' into 4198-dont-redirect
doc-han f798b53
Merge branch 'main' into 4198-dont-redirect
doc-han File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -136,7 +136,7 @@ export function useRunRetry({ | |
| // Retry state tracking via HistoryStore (WebSocket updates) | ||
| // Note: Connection management is handled by the parent component (FullScreenIDE or ManualRunPanel) | ||
| // This hook only reads the current run state from HistoryStore | ||
| const { params } = useURLState(); | ||
| const { params, updateSearchParams } = useURLState(); | ||
| const followedRunId = params.run ?? null; // 'run' param is run ID | ||
| const currentRun = useActiveRun(); // Real-time from WebSocket | ||
|
|
||
|
|
@@ -293,9 +293,9 @@ export function useRunRetry({ | |
| onRunSubmitted(response.data.run_id, response.data.dataclip); | ||
| // Don't reset isSubmitting here - the effect will do it when WebSocket connects | ||
| } else { | ||
| // Fallback: navigate away if no callback (for standalone mode) | ||
| // Don't reset isSubmitting - the page is redirecting and resetting would cause a flash | ||
| window.location.href = `/projects/${projectId}/runs/${response.data.run_id}`; | ||
| // No callback - stay on the current page and track the run in the URL | ||
| updateSearchParams({ run: response.data.run_id }); | ||
| setIsSubmitting(false); | ||
| } | ||
| } catch (error) { | ||
| logger.error('Failed to submit run:', error); | ||
|
|
@@ -391,9 +391,10 @@ export function useRunRetry({ | |
| onRunSubmitted(result.data.run_id); | ||
| // Don't reset isSubmitting here - the effect will do it when WebSocket connects | ||
| } else { | ||
| // Fallback: navigate to new run (component will unmount) | ||
| // Don't reset isSubmitting - the page is redirecting and resetting would cause a flash | ||
| window.location.href = `/projects/${projectId}/runs/${result.data.run_id}`; | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here - don't redirect! |
||
| // No callback - stay on the current page and track the run in the URL | ||
| updateSearchParams({ run: result.data.run_id }); | ||
| setIsSubmitting(false); | ||
| isRetryingRef.current = false; | ||
| } | ||
| } catch (error) { | ||
| logger.error('Failed to retry run:', error); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the change - don't redirect away from the canvas!