Update photoscan reconstruction to use Meshroom 2025#445
Merged
ebrahimebrahim merged 2 commits intomainfrom Apr 10, 2026
Merged
Update photoscan reconstruction to use Meshroom 2025#445ebrahimebrahim merged 2 commits intomainfrom
ebrahimebrahim merged 2 commits intomainfrom
Conversation
Contributor
Author
|
I compared the output of Meshroom 2023 and 2025. The reconstruction looks accurate but I noticed there is a slight difference in the color appearance of the model. I haven't changed anything in the pipeline, so the texturing differences are likely due to changes in Meshroom itself - the release mentions some changes to color calibration. |
ebrahimebrahim
approved these changes
Apr 10, 2026
Collaborator
ebrahimebrahim
left a comment
There was a problem hiding this comment.
This looks great, thank you!
Collaborator
|
Thank you also for testing and comparing outputs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #427
Updates OpenLIFU's photoscan reconstruction pipeline to be compatible with Meshroom 2025.1.0, replacing the previously supported Meshroom 2023.3.0.
Main changes:
Pipeline files (src/openlifu/nav/meshroom_pipelines/*.mg)
describerTypes: ["dspsift"]toFeatureExtractionnodes, reflecting a new required field in Meshroom 2025photoscan.py
--cacheCLI flag with --save <project_file> since Meshroom 2025 seems to ignore the--cachespec and instead writes cache output to MeshroomCache/ inside the working directorycache_dirpath accordingly (temp_dir / "MeshroomCache")"CameraInit"to"CameraInit_1"to match the node naming convention used in the updated pipeline files