Close dashboard auth boundary follow-up#1465
Merged
Jurij89 merged 6 commits intoJul 6, 2026
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveRequestAuthDecision()before the dashboard source builds an accepted request context.RequestContext.requestIdentityas the canonical route identity while preservingrequestAuth,requestToken, andrequestAgentAddresscompatibility aliases.Files Changed
packages/cli/src/auth.tspackages/cli/src/daemon/dashboard-session-auth-source.tspackages/cli/src/daemon/dashboard-sse-session.tspackages/cli/src/daemon/handle-request.tspackages/cli/src/daemon/lifecycle.tspackages/cli/src/daemon/route-request-identity.tspackages/cli/src/daemon/routes/context.tspackages/cli/test/dashboard-*.test.tspackages/cli/test/route-request-identity-dashboard.test.tspackages/cli/test/dashboard-session-test-harness.tspackages/cli/vitest.unit.config.tsVerification
pnpm install --frozen-lockfilepnpm run build:runtime:packagescd packages/cli && pnpm exec vitest run test/auth.test.ts test/dashboard-login.test.ts test/dashboard-session-auth-source.test.ts test/dashboard-session-cookie.test.ts test/dashboard-session-store.test.ts test/dashboard-session.test.ts test/route-request-identity-dashboard.test.ts --config vitest.unit.config.ts- 116 tests passedcd packages/node-ui && pnpm exec vitest run test/app-primer-route.test.ts test/dashboard-session-gate.test.ts test/dashboard-session-client.test.ts --reporter=dot- 12 tests passedcd packages/cli && pnpm exec tsc --noEmit --pretty falsegit diff --checkBroader Unit Note
I also ran
cd packages/cli && timeout 8m pnpm exec vitest run --config vitest.unit.config.ts. It completed with unrelated local-environment failures on this WSL host:/tmp/dkg-hardhat-ctx-9545.jsonbecause the Hardhat shared context was not running;The touched dashboard/auth suites passed in that broader run.