Don't blocklist GET requests, instead allowlist POST requests#19
Open
mhagander wants to merge 2 commits into
Open
Don't blocklist GET requests, instead allowlist POST requests#19mhagander wants to merge 2 commits into
mhagander wants to merge 2 commits into
Conversation
There are many more request types than GET and POST, and there is no reason to accept them.
HTTP has a standard status code when using the wrong method, so use that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are many more request types than GET and POST, and there is no reason to accept them.
(Not a high priority one, but it just flags as bad to do blocking of a single one when we really don't want the others, so good for some hygiene)