Skip to content

Don't blocklist GET requests, instead allowlist POST requests #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mhagander wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Don't blocklist GET requests, instead allowlist POST requests #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b82b772
Don't blocklist GET requests, instead allowlist POST requests
mhagander Jun 1, 2026
ca21246
Fix http status code for method not allowed
mhagander Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cgi-bin/pgstatus.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,12 @@

my $query = CGI->new;

# don't let people play games with GET requests - this should be called via POST
# don't let people play games with GET (or other) requests - this should be called via POST
# the URL should only contain the signature
if ($query->request_method eq 'GET')
if ($query->request_method ne 'POST')
{
print
"Status: 496 wrong request method\nContent-Type: text/plain\n\n",
"Status: 405 Method Not Allowed\nContent-Type: text/plain\n\n",
"wrong request method\n";
exit;
}
Expand Down