Allow custom block shapes to have a base internal/external padding#44
Open
the-can-of-soup wants to merge 2 commits intoPenguinMod:developfrom
Open
Allow custom block shapes to have a base internal/external padding#44the-can-of-soup wants to merge 2 commits intoPenguinMod:developfrom
the-can-of-soup wants to merge 2 commits intoPenguinMod:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
There is no easy way for a custom block shape to specify an internal/external padding that should apply for all other shapes.
Proposed Changes
Allows the
basekey to be used inblockPadding.internalorblockPadding.externalof custom block shapes. This will add a "base" padding that will apply to all other shapes, and will be combined with any specific paddings.Reason for Changes
This makes it easier to create proper padding for custom block shapes and improves base compatibility between extensions.