Skip to content

Allow custom block shapes to have a base internal/external padding #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
the-can-of-soup wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Allow custom block shapes to have a base internal/external padding #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13b4b20
add `base` outer block shape
the-can-of-soup Apr 12, 2026
80c91d7
add functionality of `base` outer block shape
the-can-of-soup Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions core/block_render.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,8 @@ Blockly.BlockSvg.FIELD_TEXTINPUT_ANIMATE_POSITIONING = false;
* See also: `Blockly.BlockSvg.computeOutputPadding_`.
*/
Blockly.BlockSvg.SHAPE_IN_SHAPE_PADDING = {
base : { // Outer shape: any.
},
1 : { // Outer shape: hexagon.
0 : 5 * Blockly.BlockSvg.GRID_UNIT, // Field in hexagon.
1 : 2 * Blockly.BlockSvg.GRID_UNIT, // Hexagon in hexagon.
Expand Down Expand Up @@ -1316,8 +1318,11 @@ Blockly.BlockSvg.prototype.computeOutputPadding_ = function(inputRows) {
row.paddingStart += customShape.blockPaddingStart(this, otherShape, firstInput, firstField, row);
}

const paddingStart = (Blockly.BlockSvg.SHAPE_IN_SHAPE_PADDING[shape] || {})[otherShape];
row.paddingStart += paddingStart === undefined ? Blockly.BlockSvg.DEFAULT_SHAPE_PADDING : paddingStart;
const internalPadding = (Blockly.BlockSvg.SHAPE_IN_SHAPE_PADDING[shape] || {});
const paddingStart = internalPadding[otherShape] ?? Blockly.BlockSvg.DEFAULT_SHAPE_PADDING
+ internalPadding.base ?? 0
+ Blockly.BlockSvg.SHAPE_IN_SHAPE_PADDING.base[otherShape] ?? 0;
row.paddingStart += paddingStart;

// End row padding: based on last input or last field.
var lastInput = row[row.length - 1];
Expand Down Expand Up @@ -1353,8 +1358,10 @@ Blockly.BlockSvg.prototype.computeOutputPadding_ = function(inputRows) {
row.paddingEnd += customShape.blockPaddingEnd(this, otherShape, lastInput, lastField, row);
}

const paddingEnd = (Blockly.BlockSvg.SHAPE_IN_SHAPE_PADDING[shape] || {})[otherShape];
row.paddingEnd += paddingEnd === undefined ? Blockly.BlockSvg.DEFAULT_SHAPE_PADDING : paddingEnd;
const paddingEnd = internalPadding[otherShape] ?? Blockly.BlockSvg.DEFAULT_SHAPE_PADDING
+ internalPadding.base ?? 0
+ Blockly.BlockSvg.SHAPE_IN_SHAPE_PADDING.base[otherShape] ?? 0;
row.paddingEnd += paddingEnd;
};

/**
Expand Down